Implementing Code Review Comments #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 27, 2016 10:40
Removed AzureRM.RecoveryServices.psd1 from $(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup as only the module's psd file need to be here.
…viders and Test projects as this is an unnecessary reference.
| @@ -121,9 +121,9 @@ private void HandleException(Exception exception) | |||
| } | |||
| } | |||
|
|
|||
| public override void ExecuteCmdlet() | |||
| protected override void BeginProcessing() | |||
| { | |||
There was a problem hiding this comment.
You need to also change in all cmdlets to call BeginProcessing instead of ExecuteCmdlet
There was a problem hiding this comment.
No need to override in every cmdlet. This would be run once per cmdlet by the ps infra itself.
added 5 commits
April 27, 2016 16:43
…ame throughout the solution
pragrawa
pushed a commit
that referenced
this pull request
Oct 6, 2017
Add warning to New-AzsSubscription and Get-AzureRmOffer cmdlets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.