Skip to content

PR comments #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Apr 27, 2016
Merged

PR comments #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
4cbf0fc
Wxi file fix
Apr 27, 2016
a1a399d
Removing Commands.RecoveryServices csproj reference from Cmdlets, Pro…
Apr 27, 2016
6c49d0d
Moving cmdlet initialization from ExecuteCmdlet to BeginProcessing
Apr 27, 2016
9b6f12e
Added null checks in handle created job method
Apr 27, 2016
199ef63
Renamed all occurences of Hydra to ServiceClient
Apr 27, 2016
fc38c44
Removed app config code from ServiceClientAdapter
Apr 27, 2016
d217cc6
Fixing assembly version of Service Client DLL reference in csprojs
Apr 27, 2016
55bda92
Shortened model names
Apr 27, 2016
43d3e54
Ensured that the class names and file names are in sync wherever poss…
Apr 27, 2016
e9cb85d
Missed some changes in the prev commit
Apr 27, 2016
a5128a8
Missed some files in the prev commit
Apr 27, 2016
63e1e26
Ensured package versions of Microsoft.Azure.Management.Resources is s…
Apr 27, 2016
b512a15
PR comment (reduce the line size)
mkherani Apr 27, 2016
f2aeb45
Merge pull request #308 from MabOneSdk/anudeeb-dev1
Apr 27, 2016
e57be42
Merge from dev1
mkherani Apr 27, 2016
6e8c3fa
Moved RmClient to base cmdlet class
Apr 27, 2016
e65bfea
Moved RmClient to base cmdlet class (#309)
Apr 27, 2016
e065298
PR comments
mkherani Apr 27, 2016
7161ff3
Merge dev1
mkherani Apr 27, 2016
58c371c
Fixing merge issues
mkherani Apr 27, 2016
3f90bde
Updated output type of cmdlets to match the possible outputs
Apr 27, 2016
43484d5
Merge dev1
mkherani Apr 27, 2016
61569f7
Review Comments Addressed (#310)
Apr 27, 2016
21842f7
Addinng comment section on classes
pragrawa Apr 27, 2016
bd180f3
Line break
mkherani Apr 27, 2016
fb4d9f5
Line break
mkherani Apr 27, 2016
d9d406e
Merge conflicts from dev1
pragrawa Apr 27, 2016
a2719f5
Fixing Line break
mkherani Apr 27, 2016
f101a2a
Merge conflicts
pragrawa Apr 27, 2016
06ea5d7
Merge conflicts Part 2
pragrawa Apr 27, 2016
8dd0162
Updated wxi file
Apr 27, 2016
f5c7517
Merge conflicts resolve
pragrawa Apr 27, 2016
e1c3df3
Merge conflicts resolve
pragrawa Apr 27, 2016
1cf03b1
Merge branch 'dev1' of https://github.com/MabOneSdk/azure-powershell …
pragrawa Apr 27, 2016
f02aa23
Merge conflicts Part2
pragrawa Apr 27, 2016
6a86536
Merge pull request #312 from MabOneSdk/pragrawa-dev1
pragrawa Apr 27, 2016
cd000fa
Adding comments to provider classes
pragrawa Apr 27, 2016
86a1bb5
Merge pull request #313 from MabOneSdk/pragrawa-dev1
pragrawa Apr 27, 2016
a523cfc
Revert "Removed app config code from ServiceClientAdapter"
mkherani Apr 27, 2016
693ea97
Adding comments for provider members
pragrawa Apr 27, 2016
643b0fd
Merge pull request #314 from MabOneSdk/pragrawa-dev1
pragrawa Apr 27, 2016
34f8c2a
Fixing renaming of some missed models and format xml
Apr 27, 2016
12fa9ca
Removed unnecessary lines from AzureResourceManager.psd1
Apr 27, 2016
0da5bb7
Merge pull request #315 from MabOneSdk/anudeeb-dev1
sudhakar4171 Apr 27, 2016
f04d412
Updated help xml with latest names
Apr 27, 2016
f8d8efd
Merge branch 'anudeeb-dev1' into dev1
Apr 27, 2016
7759a4c
Merge branch 'release' into dev1
sudhakar4171 Apr 27, 2016
7a44e68
Updated Microsoft.Azure.Management.Resources version in Test csproj t…
Apr 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions setup/azurecmdfiles.wxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2002,9 +2002,6 @@
<Component Id="cmp131A9DE83A67006D51F1314A42E399CA" Guid="*">
<File Id="filA2C0D97A8033046D96249BA12C24D9D4" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\AzureRM.RecoveryServices.Backup.psd1" />
</Component>
<Component Id="cmpEB886EAAAF58ED0808ACCABDCC7707CA" Guid="*">
<File Id="filB0E96893813842B67380A6863ABBCC0D" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\AzureRM.RecoveryServices.psd1" />
</Component>
<Component Id="cmpB35FF47D728C871816F14A3529260DE9" Guid="*">
<File Id="fil4BCDE7803B14A0BC88A83E82379716A7" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Hyak.Common.dll" />
</Component>
Expand Down Expand Up @@ -2032,9 +2029,6 @@
<Component Id="cmpB7B864E9C70EE65B799C79119DF7E80B" Guid="*">
<File Id="fil53BEB99E0373F87AA8C1DE1E39F13115" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.Helpers.dll" />
</Component>
<Component Id="cmp298EE60DD6AAA12C33CA9E9EDDE4D674" Guid="*">
<File Id="filCA9A0EEBDB33D088D4D0EB9555189CD6" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.HydraAdapter.dll" />
</Component>
<Component Id="cmp8826130AB84A23A8748B2E58087F1733" Guid="*">
<File Id="filBDEE1F034CEDF43D3B10E1DCA9DF81C0" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.Logger.dll" />
</Component>
Expand All @@ -2044,6 +2038,9 @@
<Component Id="cmp3CBA7972F4711484D7FFF19457023268" Guid="*">
<File Id="filFEB151053DDC35E6643F363B07EC1EE3" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.Providers.dll" />
</Component>
<Component Id="cmpB57F8F8298BF0638BFC679D217D71961" Guid="*">
<File Id="fil0D19F831018B79D88CF568D14CC27CA3" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.ServiceClientAdapter.dll" />
</Component>
<Component Id="cmpDD61A35D79AF0DB08D533DDD646150DC" Guid="*">
<File Id="filF23BA348008E142BB0CEBEBDBD6F0B09" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.ResourceManager.Common.dll" />
</Component>
Expand Down Expand Up @@ -5717,7 +5714,6 @@
<ComponentRef Id="cmpC00974919B90C9055BED1F2A9DA95441" />
<ComponentRef Id="cmpE300D8B185C427E05E95BA97413F6CC8" />
<ComponentRef Id="cmp131A9DE83A67006D51F1314A42E399CA" />
<ComponentRef Id="cmpEB886EAAAF58ED0808ACCABDCC7707CA" />
<ComponentRef Id="cmpB35FF47D728C871816F14A3529260DE9" />
<ComponentRef Id="cmp99A277F4A4EF20D7BFBB171691A4B7E7" />
<ComponentRef Id="cmp1675F88279F58B72A180AF1411111337" />
Expand All @@ -5727,10 +5723,10 @@
<ComponentRef Id="cmpC9D832735AB0EF3B4F1309E307393863" />
<ComponentRef Id="cmp7E42CC4AEA15FEF46E621AD38CC09F5A" />
<ComponentRef Id="cmpB7B864E9C70EE65B799C79119DF7E80B" />
<ComponentRef Id="cmp298EE60DD6AAA12C33CA9E9EDDE4D674" />
<ComponentRef Id="cmp8826130AB84A23A8748B2E58087F1733" />
<ComponentRef Id="cmp705D3AFB5E86339823E569C4645A139F" />
<ComponentRef Id="cmp3CBA7972F4711484D7FFF19457023268" />
<ComponentRef Id="cmpB57F8F8298BF0638BFC679D217D71961" />
<ComponentRef Id="cmpDD61A35D79AF0DB08D533DDD646150DC" />
<ComponentRef Id="cmp577E28EE57A416E3052CEE1BD21E5990" />
<ComponentRef Id="cmp403248FE1CECDB2218740975E268E81C" />
Expand Down
10 changes: 3 additions & 7 deletions .../Commands.RecoveryServices.Backup.Helpers/Commands.RecoveryServices.Backup.Helpers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<Reference Include="Microsoft.Azure.Common">
<HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Azure.Management.RecoveryServices.Backup, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<Reference Include="Microsoft.Azure.Management.RecoveryServices.Backup, Version=0.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.Azure.Management.RecoveryServices.Backup.0.1.0-preview\lib\net40\Microsoft.Azure.Management.RecoveryServices.Backup.dll</HintPath>
</Reference>
Expand All @@ -52,23 +52,19 @@
<ItemGroup>
<Compile Include="Conversions\JobConversions.cs" />
<Compile Include="Conversions\RecoveryPointConversions.cs" />
<Compile Include="Utils.cs" />
<Compile Include="HelperUtils.cs" />
<Compile Include="Validations\PolicyValidations.cs" />
<Compile Include="Conversions\SchedulePolicyConversions.cs" />
<Compile Include="Conversions\RetentionPolicyConversions.cs" />
<Compile Include="Conversions\ConversionHelpers.cs" />
<Compile Include="HydraHelpers.cs" />
<Compile Include="ServiceClientHelpers.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\Common\Commands.Common\Commands.Common.csproj">
<Project>{5ee72c53-1720-4309-b54b-5fb79703195f}</Project>
<Name>Commands.Common</Name>
</ProjectReference>
<ProjectReference Include="..\Commands.RecoveryServices.Backup.HydraAdapter\Commands.RecoveryServices.Backup.HydraAdapter.csproj">
<Project>{b758fec1-35c1-4f93-a954-66dd33f6e0ec}</Project>
<Name>Commands.RecoveryServices.Backup.HydraAdapter</Name>
</ProjectReference>
<ProjectReference Include="..\Commands.RecoveryServices.Backup.Logger\Commands.RecoveryServices.Backup.Logger.csproj">
<Project>{5e675749-6139-464a-904c-59c0ffdfec82}</Project>
<Name>Commands.RecoveryServices.Backup.Logger</Name>
Expand Down
Loading