-
Notifications
You must be signed in to change notification settings - Fork 2
Fixing 7349803 in Cmdlet Layer #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5554791
2533568
a052122
21856fc
2183e6a
08e83ee
21b3b91
1a1941b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,32 +25,47 @@ | |
namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets | ||
{ | ||
/// <summary> | ||
/// Get list of containers | ||
/// Fetches containers registered to the item according to the filters passed via the cmdlet parameters. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Registered to the vault, you mean? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed |
||
/// </summary> | ||
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupContainer"), | ||
OutputType(typeof(ContainerBase), typeof(IList<ContainerBase>))] | ||
public class GetAzureRmRecoveryServicesBackupContainer : RecoveryServicesBackupCmdletBase | ||
{ | ||
/// <summary> | ||
/// The type of the container(s) to be fetched. | ||
/// </summary> | ||
[Parameter(Mandatory = true, Position = 1, HelpMessage = ParamHelpMsgs.Container.ContainerType)] | ||
[ValidateNotNullOrEmpty] | ||
public ContainerType ContainerType { get; set; } | ||
|
||
/// <summary> | ||
/// The backup management type of the container(s) to be fetched. | ||
/// </summary> | ||
[Parameter(Mandatory = false, Position = 2, | ||
HelpMessage = ParamHelpMsgs.Container.BackupManagementType)] | ||
[ValidateNotNullOrEmpty] | ||
[ValidateSet("AzureVM", "MARS")] | ||
public string BackupManagementType { get; set; } | ||
|
||
/// <summary> | ||
/// Friendly name of the container(s) to be fetched. | ||
/// </summary> | ||
[Parameter(Mandatory = false, Position = 3, | ||
HelpMessage = ParamHelpMsgs.Container.Name)] | ||
[ValidateNotNullOrEmpty] | ||
public string Name { get; set; } | ||
|
||
/// <summary> | ||
/// Resource group name of the container(s) to be fetched. | ||
/// </summary> | ||
[Parameter(Mandatory = false, Position = 4, | ||
HelpMessage = ParamHelpMsgs.Container.ResourceGroupName)] | ||
[ValidateNotNullOrEmpty] | ||
public string ResourceGroupName { get; set; } | ||
|
||
/// <summary> | ||
/// Status of the registration of the container with the recovery services vault. | ||
/// </summary> | ||
[Parameter(Mandatory = false, Position = 5, | ||
HelpMessage = ParamHelpMsgs.Container.Status)] | ||
[ValidateNotNullOrEmpty] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,18 +24,27 @@ | |
|
||
namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets | ||
{ | ||
/// <summary> | ||
/// Cancels a job. Returns the corresponding job object after this operation finishes. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. *after trigger of cancellation finishes. It need not cancel it successfully. It will only notify the service that a cancellation has been triggered. Please convey this in any way you like. :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cancels a job. Returns the corresponding job object after the trigger of the cancellation finishes. The job may not cancel successfully. The cmdlet will ensure that the service is notified that a cancellation has been triggered. |
||
/// </summary> | ||
[Cmdlet("Stop", "AzureRmRecoveryServicesBackupJob", DefaultParameterSetName = JobFilterSet), | ||
OutputType(typeof(JobBase))] | ||
public class StopAzureRmRecoveryServicesBackupJob : RecoveryServicesBackupCmdletBase | ||
{ | ||
protected const string IdFilterSet = "IdFilterSet"; | ||
protected const string JobFilterSet = "JobFilterSet"; | ||
|
||
/// <summary> | ||
/// Job which needs to be canceled. | ||
/// </summary> | ||
[Parameter(Mandatory = true, HelpMessage = ParamHelpMsgs.Job.StopJobJobFilter, | ||
ParameterSetName = JobFilterSet, Position = 1)] | ||
[ValidateNotNull] | ||
public JobBase Job { get; set; } | ||
|
||
/// <summary> | ||
/// ID of the job which needs to be canceled. | ||
/// </summary> | ||
[Parameter(Mandatory = true, HelpMessage = ParamHelpMsgs.Job.StopJobJobIdFilter, | ||
ParameterSetName = IdFilterSet, Position = 2)] | ||
[ValidateNotNull] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term enabled is misleading. This commandlet takes adhoc backup. Can you rephrase it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The protected item on which backup has to be triggered