RS Backup PS Swagger Migration #357

dragonfly91 · 2016-11-10T16:23:14Z

No description provided.

Merge from master

… standard storage

…emoved it, but c4f3923 brought it back by mistake. So now removing it again to completely remove from the repo

…e after retirement date

Fix Set-AzureRmOperationalInsightsSavedSearch ETag

harden default keyvault permission set

pragrawa · 2016-11-11T07:18:55Z

src/ResourceManager/RecoveryServices/Commands.RecoveryServices/Commands.RecoveryServices.csproj

@@ -60,8 +60,8 @@
      <Private>True</Private>
    </Reference>
    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
+      <SpecificVersion>False</SpecificVersion>


False [](start = 6, length = 40)

Remove changes in this file #Closed

pragrawa · 2016-11-11T07:19:31Z

using System.Net.Security;

Keep System usings first #Closed

Refers to: src/ResourceManager/RecoveryServices/Commands.RecoveryServices/Common/PSRecoveryServicesClient.cs:23 in 302e2ba. [](commit_id = 302e2bafce0b2335f6bd232d2950f3c4d628bf56, deletion_comment = False)

pragrawa · 2016-11-11T07:20:02Z

...ourceManager/RecoveryServices/Commands.RecoveryServices/Common/RecoveryServicesCmdletBase.cs

 using System.Runtime.Serialization;
 using System.Xml;
 using Hyak.Common;
-using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using Microsoft.Azure.Commands.ResourceManager.Common;
 using Newtonsoft.Json;
 using System.Text;


System.Text; [](start = 6, length = 12)

System usings first #Closed

pragrawa · 2016-11-11T07:20:32Z

using System.Net.Security;

See in other files also

In reply to: 259896841 [](ancestors = 259896841)

Refers to: src/ResourceManager/RecoveryServices/Commands.RecoveryServices/Common/PSRecoveryServicesClient.cs:23 in 302e2ba. [](commit_id = 302e2bafce0b2335f6bd232d2950f3c4d628bf56, deletion_comment = False)

pragrawa · 2016-11-11T07:22:07Z

...ices.Backup/Commands.RecoveryServices.Backup/Commands.RecoveryServices.Backup.Cmdlets.csproj

@@ -47,9 +47,9 @@
      <SpecificVersion>False</SpecificVersion>
      <HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.dll</HintPath>
    </Reference>
-    <Reference Include="Microsoft.Azure.Management.RecoveryServices.Backup, Version=0.9.0.0, Culture=neutral, processorArchitecture=MSIL">
+    <Reference Include="Microsoft.Azure.Management.RecoveryServices.Backup, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


31bf3856ad364e35 [](start = 125, length = 16)

What is Public Token key here, will it be same for all project reference ? #WontFix

This was added automatically by VS. I'm not sure what this is about.

In reply to: 87546813 [](ancestors = 87546813)

pragrawa · 2016-11-11T07:23:17Z

...RecoveryServices.Backup/Commands.RecoveryServices.Backup/RecoveryServicesBackupCmdletBase.cs

+            base.SetupHttpClientPipeline();
+            AzureSession.ClientFactory.AddHandler(new RpNamespaceHandler(ServiceClientAdapter.ResourceProviderNamespace));
+            AzureSession.ClientFactory.AddHandler(new ClientRequestIdHandler());
+            //AzureSession.ClientFactory.AddHandler(new CultureHandler());


//AzureSession.ClientFactory.AddHandler(new CultureHandler()); [](start = 12, length = 62)

Remove commented code #Closed

pragrawa · 2016-11-11T07:23:50Z

...RecoveryServices.Backup/Commands.RecoveryServices.Backup/RecoveryServicesBackupCmdletBase.cs

@@ -61,6 +59,14 @@ protected void InitializeAzureBackupCmdlet()
            Logger.Instance = new Logger(WriteWarning, WriteDebug, WriteVerbose, ThrowTerminatingError);
        }

+        protected override void SetupHttpClientPipeline()


protected override void SetupHttpClientPipeline() [](start = 8, length = 49)

Add also small summary for this function
#Closed

pragrawa · 2016-11-11T07:24:38Z

...RecoveryServices.Backup/Commands.RecoveryServices.Backup/RecoveryServicesBackupCmdletBase.cs

-                    var cloudEx = exception as CloudException;
-                    if (cloudEx.Response != null && cloudEx.Response.StatusCode == HttpStatusCode.NotFound)
+                    var cloudEx = exception as AzureRestNS.CloudException;
+                    if (cloudEx.Response != null && cloudEx.Response.StatusCode == System.Net.HttpStatusCode.NotFound)


System.Net.HttpStatusCode.NotFo [](start = 83, length = 31)

Use some alias instead of full namespace #Closed

pragrawa · 2016-11-11T07:25:17Z

...RecoveryServices.Backup/Commands.RecoveryServices.Backup/RecoveryServicesBackupCmdletBase.cs

@@ -171,42 +177,42 @@ public List<CmdletModel.JobBase> GetJobObject(IList<string> jobIds)
        /// <summary>
        /// Based on the response from the service, handles the job created in the service appropriately.
        /// </summary>
-        /// <param name="itemResponse">Response from service</param>
+        /// <param name="jobResponse">Response from service</param>


jobResponse [](start = 25, length = 11)

param name is response #Closed

pragrawa · 2016-11-11T07:28:21Z

...Backup/Commands.RecoveryServices.Backup/Cmdlets/Jobs/StopAzureRmRecoveryServicesBackupJob.cs

@@ -66,10 +63,15 @@ public override void ExecuteCmdlet()

                var cancelResponse = ServiceClientAdapter.CancelJob(JobId);

-                if (cancelResponse.StatusCode != HttpStatusCode.NoContent)
+                // Add tracking part


// Add tracking part [](start = 16, length = 20)

Write comments in more detail #Resolved

Adding retirement message for managed cache customers who will perform powershell commands on managed cache post retirement date

Search code base for any deprecation warning and remove it

Merge "Adding storage account properties to SQL threat detection cmdlets"

…into dev

Adding storage account properties to SQL threat detection cmdlets

…lp file

Azure powershell SDK changes for Notification Hubs. Added a skuTier parameter for create/update namespace.

…Database, Server and Elastic Pool (Azure#3206) * Fixed Azure Sql Tags for Database, server and elastic pools. * Fixed Azure Sql Tags for Database, server and elastic pools on both GET and SET. Fixed SET server command. * Added tests and addressed comments from code review. * Added tests and addressed comments from code review.

* refactoring task modules * missed Refactoring modules * Making modular modules for various tasks * Added cmdlet to create Service Principal. Refactored Repo-Tasks to include multiple modular modules (e.g. Build-Tasks, TestFx-Tasks) * Removing SPN cmdlets

* enabling disabled tests * updating test category as CheckinTests. Fixed the cmdlet directory path to be included while running static analysis on test cmdlet assembly

* Added -JsonAttributes option to set custom json attributes in first-boot.json Signed-off-by: Vasu1105 <[email protected]> * Fixed multiple condition for SetAzureVMChefExtension command in Resource Management, Updated -JsonAttribute description with example, Added new -ChefServiceInterval option Signed-off-by: Vasu1105 <[email protected]> * Refactored code for Chef extension Set-AzureVMChefExtension Service management command to reduce multiple conditions Signed-off-by: Vasu1105 <[email protected]> * Fixed review comments Signed-off-by: Vasu1105 <[email protected]> * Added automated test for Set-AzureVMChefExtension Signed-off-by: Vasu1105 <[email protected]> * Regenerated record for automated test Signed-off-by: Vasu1105 <[email protected]> * Added code to get current directory Signed-off-by: Vasu1105 <[email protected]> * Added global exception for crdential files Signed-off-by: Vasu1105 <[email protected]> * Updated changelog.md Signed-off-by: Vasu1105 <[email protected]>

Update libraries for Adal 2.28.3

- If ApiId is not provided, generate it.

Change deployment polling polling logic.

Migrating cmdlet code base to swagger. Swagger changes for job conversion, job adapter, policy adapter Swagger Changes Swagger changes. SwaggerChanges in Provider sln Swagger changes swagger changes swagger changes. Added latest swaggerDlls Migrated PO calls to swagger Swagger changes for Policy and Job model Infra part 1 Removed custom request headers, as client request ID will be passed via the Delegating Handler Swagger changes Part2 for Jobs and Policy Mkherani swagger (#354) * Container: ServiceCLient and conversionHelper * Container: conversionHelper.cs * container changes completed. Updating swagger dll Migrating common job tracking to Swagger. Swagger: fixed build Swagger changes Swagger changes for Policy/Jobs Tracking Helper Status code change RecoveryServicesBackupClient init hack in test Adding Microsoft.Rest.ClientRuntime.Azure to packages config Adding Microsoft.Rest.ClientRuntime.Azure to package config files of ServiceClientAdapter and Test Auth changes due to autorest in service client adapter, base cmdlet and base test. Correcting the reference for Microsoft.Rest.ClientRuntime.dll Changed auth dll reference Fixed internal constructors in the client Fixing build issue Updated latest DLL and made fixes Added Microsoft.Rest.ClientRuntime.Azure ref to Models proj. Fixing build break Fixing issue in job ListRP fix DateTime changes Updated to latest AutoRest DLL Updated latest AutoRest DLL fixed datetime format DateTime fix Exception handling changes Updated latest AutoRest DLL Added QueryBuilder util Added ToCamelCase string extension Fixing issues with query filters. Fixing filter for GetRPList Enum and query builder fixes Updated AutoRest DLL. fixed container bug with polymorphism Fix for pagination in HelperUtil.cs Fix for operation status tracking using location header Fixing issues with datetime, policy and query filters. Fixing query filter issue except datetime filter Fix for policy filter Updated latest Swagger DLL - used UTC converter for serialization, removed ContainerType enum and made corresponding changes. wix file changes and set-policy cmdlet fix Get policy filter fix Get Policy fix for default backup management type Fixed test infra and ready for recording.

Added time Filter negative test and session record for GetRP and GetJobTimeFilter Job Wait and Cancel records Merged GetRP and restore test to save run time. Added session record for GetRP and backup item test case. Added AzureVM Workload trait to tests Removing restore cmdlet call from getRP. Fixing MSI build break. Updated Client Request ID to include "-PS" Added "-PS" to client request ID Fixed namespaces Fixed container API bug and recorded MAB test cases Undoing changes to authentication csproj file Undoing changes to Commands Common csproj undoing changes to commands common csproj undoing changes to cognitive services sln undoing changes Undoing unwanted changes 1. Undoing unwated changes to csproj files and 2. Kept system using first Fixing build recording for Azure Sql PaaS workload cmdlets. Addressed CR comments Addressed CR comments Taken code guideline - every line should be 100 chars of less. Recorded DPM tests and added session records Fixing mistakes in comments Using aliases for namespaces wherever possible. namespace alias changes

Formatting changes Removed extra empty lines sorted and pruned usings

Moving to nuget dependencies Removing unwanted changes from test case

Undone edits to common changelog and updated project specific changelog.

yaakoviyun and others added 20 commits May 26, 2016 09:25

Merge pull request #9 from Azure/dev

09d083e

Merge from master

Merge remote-tracking branch 'refs/remotes/Azure/dev' into dev

206fab1

fix error in Test-AzureRmVMAEMExtension and improve error message for…

188e54f

… standard storage

Disable Windows Azure Diagnostics per default

3424d30

remove position parameter from switch parameters

579d8db

Merge remote-tracking branch 'refs/remotes/Azure/dev' into dev

ac22a3d

deleting AzStack refernces as it was checked in by mistake. c4f3923 r…

3a44723

…emoved it, but c4f3923 brought it back by mistake. So now removing it again to completely remove from the repo

Merge remote-tracking branch 'refs/remotes/Azure/dev' into dev

9e6c52f

Add Storage properties to SQL threat detection

d2c0a9f

Fix Set-AzureRmOperationalInsightsSavedSearch ETag

b0914a8

add new test suites

6ebee16

Updating help contents

3f9b11d

add new test records

b3976bd

Adding managed cache retirement message for customers trying to creat…

9636d67

…e after retirement date

removing AuditActions from server cmdlets

9aa044b

Updating tests

a161b21

Updating failed test

708ddab

Merge pull request Azure#3184 from lwang2016/dev

77f543f

Fix Set-AzureRmOperationalInsightsSavedSearch ETag

Update AzureDiskEncryptionPreRequisiteSetup.ps1

10fc37e

harden default keyvault permission set

add tests for Error message

d24306e

pragrawa reviewed Nov 11, 2016

View reviewed changes

dragonfly91 force-pushed the devSwagger branch from d2fc228 to 5d33eb2 Compare November 19, 2016 14:35

markcowl and others added 11 commits November 21, 2016 01:39

Merge pull request Azure#3193 from alfantp/dev

2e85ebd

Adding retirement message for managed cache customers who will perform powershell commands on managed cache post retirement date

Merge pull request Azure#3195 from Azure/ilahat

52444bf

Search code base for any deprecation warning and remove it

Added Sku parameter and changed tests

055aaf0

Merge remote-tracking branch 'refs/remotes/Azure/dev' into dev

8c00b07

Merge pull request #10 from yoavrubin/dev

d04ce60

Merge "Adding storage account properties to SQL threat detection cmdlets"

Merge branch 'dev' of https://github.com/yaakoviyun/azure-powershell …

f9871ca

…into dev

Updated the changelog

ce4f7e5

Merge pull request Azure#3219 from yaakoviyun/dev

79d7377

Adding storage account properties to SQL threat detection cmdlets

Removed <Private>true</Private> and changing skuTier to SkuTier in he…

80cd89a

…lp file

Merge pull request Azure#3119 from amolr/dev

626036a

Azure powershell SDK changes for Notification Hubs. Added a skuTier parameter for create/update namespace.

Added tests with recording for AzurerM commands (Azure#2713)

58f4edd

dragonfly91 force-pushed the devSwagger branch from f51eb9f to d1e4be3 Compare November 29, 2016 12:56

vaishali33 and others added 15 commits November 29, 2016 16:20

enabling disabled tests (Azure#3229)

5cb4d2a

* enabling disabled tests * updating test category as CheckinTests. Fixed the cmdlet directory path to be included while running static analysis on test cmdlet assembly

Change deployment polling polling logic.

56aac31

Update libraries for ADAL 2.28.3

b9b8091

Update test library for common assemblies for ADAL 2.28.3

f141d59

Merge pull request Azure#3242 from markcowl/adal-2.28.3

c8fba12

Update libraries for Adal 2.28.3

Fix issue Azure#3217 (Azure#3233)

a24262c

- If ApiId is not provided, generate it.

Merge pull request Azure#3239 from TianoMS/tiano-d2

df49015

Change deployment polling polling logic.

Changelog update

648930b

Formatting changes Removed extra empty lines sorted and pruned usings

Moving to nuget dependencies

e524b3f

Moving to nuget dependencies Removing unwanted changes from test case

Changelog edits

b89e61a

Undone edits to common changelog and updated project specific changelog.

dragonfly91 force-pushed the devSwagger branch from 78e400c to b89e61a Compare December 3, 2016 03:37

Added clientruntime test framework DLL to RS Backup test project.

0d5c6a9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RS Backup PS Swagger Migration #357

RS Backup PS Swagger Migration #357

Uh oh!

dragonfly91 commented Nov 10, 2016

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

pragrawa commented Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

pragrawa commented Nov 11, 2016

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

dragonfly91 Nov 11, 2016

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

Uh oh!

Uh oh!

RS Backup PS Swagger Migration #357

Are you sure you want to change the base?

RS Backup PS Swagger Migration #357

Uh oh!

Conversation

dragonfly91 commented Nov 10, 2016

Uh oh!

pragrawa Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pragrawa commented Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pragrawa Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pragrawa commented Nov 11, 2016

Uh oh!

pragrawa Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dragonfly91 Nov 11, 2016

Choose a reason for hiding this comment

Uh oh!

pragrawa Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pragrawa Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pragrawa Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pragrawa Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pragrawa Nov 11, 2016 • edited by dragonfly91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

pragrawa commented Nov 11, 2016 •

edited by dragonfly91

Loading

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading

pragrawa Nov 11, 2016 •

edited by dragonfly91

Loading