Added Azure File Share support to disable protection

[siddharth7]

Description

---

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• I have read the contribution guidelines.
• If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
• If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• Pull request includes test coverage for the included changes.
• PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

• Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[dragonfly91]

Please refactor this

[siddharth7]

Done

[dragonfly91]

@siddharth7 I'm still seeing the EnableOrDisableProtection method. I thought this was supposed to be EnableOrModifyProtection and DisableProtection. Did anything change from our initial agreement?

[dragonfly91]

Please don't depend on policy being null for this check. Expose a boolean parameter bool disableWithRetainData and use this for this check. Also, please add some comments so that the flow will be a bit more readable.

[dragonfly91]

In this method, you are throwing an incorrect exception message with VirtualMachineIdIsEmptyOrNull. Please fix this:

     private void ValidateAzureFilesModifyProtectionRequest(ItemBase itemBase,
         PolicyBase policy)
     {
         if (itemBase == null || itemBase.GetType() != typeof(AzureFileShareItem))
         {
             throw new ArgumentException(string.Format(Resources.InvalidProtectionPolicyException,
                                         typeof(AzureFileShareItem).ToString()));
         }

         if (string.IsNullOrEmpty(((AzureFileShareItem)itemBase).ParentContainerFabricId))
         {
             throw new ArgumentException(Resources.VirtualMachineIdIsEmptyOrNull);
         }
     }

[dragonfly91]

Please make sure that all of the error messages have been signed off from PM.

[dragonfly91]

EnableOrModifyProtection(disableWithRetentionData: true);

[dragonfly91]

Please remove this

[dragonfly91]

consider swap of conditions?