Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

MAINT: appveyor conda.org uploads #74

Merged
merged 1 commit into from
May 15, 2020

Conversation

tylerjereddy
Copy link
Collaborator

  • turn on conda.org uploads for appveyor CI;
    we never did weekly uploads for Appveyor/Windows
    wheels so just turn on for merge events

  • hopefully this will restrict to merges and not
    successful PR branch runs by virtue of secret variable
    availability only within the repo itself (so most PRs
    should be opened from forks where possible)

@tylerjereddy tylerjereddy force-pushed the appveyor_merge_uploads branch from 4df9888 to 39d6928 Compare May 13, 2020 23:25
@tylerjereddy tylerjereddy force-pushed the appveyor_merge_uploads branch from 39d6928 to 55a1e8a Compare May 14, 2020 02:50
* turn on conda.org uploads for appveyor CI;
we never did weekly uploads for Appveyor/Windows
wheels so just turn on for merge events

* hopefully this will restrict to merges and not
successful PR branch runs by virtue of secret variable
availability only within the repo itself (so most PRs
should be opened from forks where possible)
@tylerjereddy tylerjereddy force-pushed the appveyor_merge_uploads branch from 55a1e8a to 2b9df1c Compare May 15, 2020 00:06
@tylerjereddy tylerjereddy changed the title WIP, MAINT: appveyor conda.org uploads MAINT: appveyor conda.org uploads May 15, 2020
@tylerjereddy
Copy link
Collaborator Author

CI finally looks good now--let's see if the appveyor staging uploads happen after a merge event.

@tylerjereddy tylerjereddy merged commit 76883d4 into MacPython:master May 15, 2020
@tylerjereddy tylerjereddy deleted the appveyor_merge_uploads branch May 15, 2020 02:11
@mattip
Copy link
Contributor

mattip commented May 15, 2020

The weekly wheels have a git hash in their name, which does not indicate chronological order. The old multiwheel uploaded added the date to allow ordering the uploads.

In numpy-wheels I added a rename function to add the date in the weekly uploads. That way pip will take the latest. It changes scipy-1.5.0.dev0+6f0b508-cp38-cp38-macosx_10_9_x86_64.whl into ` scipy-1.5.0.dev0+20200515101522_6f0b508-cp38-cp38-macosx_10_9_x86_64.whl.

The staging wheels do not need that, since they do not have a git-commit hash in their name.

@tylerjereddy
Copy link
Collaborator Author

The weekly wheels have a git hash in their name, which does not indicate chronological order. The old multiwheel uploaded added the date to allow ordering the uploads.

The conda.org site has a sorting column you can click based on upload timestamp. Not saying I'm against adding a datestamp to the weekly Travis uploads for SciPy though. May depend on how other projects consume them I guess.

Will pip check the timestamp metadata on binaries if we don't change the filenames?

The staging wheels do not need that, since they do not have a git-commit hash in their name.

Ours do have a git commit hash in their name, until the release proper. So on a merge to master the staging upload area is populated with the dev version and hash. On a release feature branch the hash would presumably be excluded to give a pure "release version."

Something is going to go wrong for the next release attempt, I can feel it... :)

@tylerjereddy
Copy link
Collaborator Author

So, for staging uploads:

  1. for final releases, yes should only have version number and are sorted that way by pip I guess
  2. otherwise, the staging area basically just contains "junk" from merges for debugging/the release manager, so the hashes without dates are probably fine there

@mattip
Copy link
Contributor

mattip commented May 15, 2020

@tylerjereddy
Copy link
Collaborator Author

I see, I guess that's an informal indication that pip may not be automagically checking timestamps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants