Skip to content

move remove_done_callback to finally block to fix RuntimeError('Event loop stopped before Future completed') #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2017
Merged

move remove_done_callback to finally block to fix RuntimeError('Event loop stopped before Future completed') #106

merged 2 commits into from
Nov 10, 2017

Conversation

jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Sep 4, 2017 •
edited
Loading

@1st1
This fix is the same as python/cpython#1688

I still don't have clear idea about how the future with callback was left over in the loop.

This fix has proven to be effective in large scale production.

@1st1 1st1 merged commit 804364c into MagicStack:master Nov 10, 2017
@1st1
Copy link
Member

1st1 commented Nov 10, 2017

Thanks @jimmylai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmylai @1st1