Add python 3.7 on CI #179
Add python 3.7 on CI #179
Conversation
> python3.7 is not available on trusty @see travis-ci/travis-ci#9831
.travis.yml
Outdated
| services: [docker] | ||
| env: BUILD=tests,wheels,release | ||
|
|
||
| cache: |
|
While you're here, please update |
|
@elprans please take a look. |
| @@ -65,6 +72,15 @@ matrix: | |||
| services: [docker] | |||
| env: BUILD=tests,wheels,release | |||
|
|
|||
| - os: linux | |||
There was a problem hiding this comment.
Yes, we only need one "release" job for Linux. The actual wheel build is done inside manylinux docker images which are selected with the RELEASE_PYTHON_VERSIONS environment variable.
There was a problem hiding this comment.
waiting https://travis-ci.org/MagicStack/uvloop/builds/400060588 to finish
may I suggest using 1 CI that support OSX / Linux / Windows (instead of 2)
I've found https://cirrus-ci.org/
There was a problem hiding this comment.
Seems that Cirrus CI is just a couple of days old. We'll wait until it's mature before spending any time trying to integrate it.
| language: python | ||
| python: "3.7" | ||
| services: [docker] | ||
| env: BUILD=tests,wheels,release |
There was a problem hiding this comment.
Could also be the same for other python versions, no ?
There was a problem hiding this comment.
It's the same for other versions. There's only one target with BUILD=tests,wheels,release (3.5) which builds the wheels and releases them. All other targets (except macos) only run tests. So 3.7 linux target should also just run tests.
| @@ -65,6 +72,15 @@ matrix: | |||
| services: [docker] | |||
| env: BUILD=tests,wheels,release | |||
|
|
|||
| - os: linux | |||
| dist: xenial | |||
| branches: {only: [releases]} | |||
| sudo: required | ||
| language: python | ||
| python: "3.7" | ||
| services: [docker] |
.travis.yml
Outdated
| python: "3.5" | ||
| services: [docker] | ||
| env: BUILD=tests,wheels,release | ||
| python: "3.7" |
There was a problem hiding this comment.
Eh, we needed to keep env: BUILD=tests. Never mind, I'll make a PR myself.
There was a problem hiding this comment.
👍 reverting my change, it will be better to refactor test after this
|
I pushed a CI change in a separate commit: 37f964b Thank you for working on this, I credited you for the change! |
|
@1st1 awesome 🎉 but why removing appveyor ? |
|
AppVeyor was testing linux+python 3.7 (uvloop doesn't support Windows yet), which is now unnecessary. |
Hi,
This
PRis an attempt to add CI on python3.73.7 is not available by default on travis / linux @see travis-ci/travis-ci#9831
Windows is already using 3.7
Regards,