Cast geometry from array

[trin4ik]

At now we can do $serialize = Model::find(35)->toArray(); but cant use $model = new Model($serialize). This PR look to values and try to use Geometry::fromJson() to serialized array.

[MatanYadaev]

Thanks for the PR. Please add tests. This package should be 100% covered with tests.

[MatanYadaev]

Please add a Geometry@fromArray method that does the same logic and use it here instead.

[trin4ik]

hi, tests added, method fromArray created

[MatanYadaev]

Please use 2 spaces instead of 4.

[MatanYadaev]

I believe this validation isn't necessary, we already validate for correctness of GeoJson here: https://github.com/MatanYadaev/laravel-eloquent-spatial/blob/master/src/Factory.php#L34

[MatanYadaev]

Please add this method to the API.md

[MatanYadaev]

I tend to keep the tests following the AAA pattern - so anything that is related to arranging the data should be above the "act" part.

Suggested change

	$geometryCollection = new GeometryCollection([
	new Polygon([
	new LineString([
	new Point(0, 180),
	new Point(1, 179),
	new Point(2, 178),
	new Point(3, 177),
	new Point(0, 180),
	]),
	]),
	new Point(0, 180),
	]);
	$geometryCollectionFromArray = GeometryCollection::fromArray($geometryCollection->toArray());
	$geometryCollection = new GeometryCollection([
	new Polygon([
	new LineString([
	new Point(0, 180),
	new Point(1, 179),
	new Point(2, 178),
	new Point(3, 177),
	new Point(0, 180),
	]),
	]),
	new Point(0, 180),
	]);
	$geometryCollectionArray = $geometryCollection->toArray();
	$geometryCollectionFromArray = GeometryCollection::fromArray($geometryCollectionArray);

[MatanYadaev]

Please move the test to the GeometryTest because it's not related to a specific geometry type.

[trin4ik]

• codestyle fixed
• throw OutOfBoundsException removed
• API documented
• test moved and fixed.

also added some test. How u run a tests? i use https://github.com/nektos/act and when i run pest/pest-coverage, i see a lot of coverage errors

[MatanYadaev]

@trin4ik Thanks!