Skip to content

Add HasSpatial trait #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Add HasSpatial trait #75

merged 4 commits into from
Jan 9, 2023

Conversation

lukevi
Copy link
Contributor

@lukevi lukevi commented Jan 4, 2023

Hi - I made this small change locally to be more "the laravel way" and thought I'd share.

Copy link
Owner

@MatanYadaev MatanYadaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left small comments.

@MatanYadaev MatanYadaev changed the title Reusable trait rather than adding a method Add HasSpatial trait Jan 5, 2023
- update readme instruction
- restore phpdoc ide hint
- trailing newline for phpcs
@lukevi
Copy link
Contributor Author

lukevi commented Jan 5, 2023

Very welcome - it's my first ever open-source contribution, so I'm glad you like it. Updates pushed.

@lukevi lukevi closed this Jan 5, 2023
@lukevi lukevi reopened this Jan 5, 2023
Copy link
Owner

@MatanYadaev MatanYadaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have lint issues, please run composer run php-cs-fixer to fix these issues.

- typo & cs-fixer fix
@lukevi lukevi requested a review from MatanYadaev January 9, 2023 14:29
@MatanYadaev MatanYadaev merged commit b00b225 into MatanYadaev:master Jan 9, 2023
@MatanYadaev
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants