Cumulative patchwork from my repo #89

iakov · 2023-01-21T16:08:17Z

Multiple improvements and fixes for QMake build system (parallel build, shadow build, make check for tests
Unit-test in CI after make check support is enabled
Undefined behavior fixed + UBSan in CI
Some memory leaks fixed
More build warnings and corresponding code cleanup
Add macOS GHA CI

* Parallel build * `make check` support * Fix `debug`/`release` builds

* Force C++11 * Disable annoying warnings for deprecated declarations * Add -Wpedantic and even -Werror for src, but relaxe some warnings * Code cleanup for less warnings

* Introduce UBSan into CI * Fix UB with incorrect alignment. This is a dirty hotfix in the rxx_allocator.

Remove unused code and redundant ctors

Missed this fix in #bc4aa1e

But really QT_NO_CAST_FROM_ASCII can help prevent incorrect behavior on non-Latin1 input

build/python.prf

he-hesce · 2023-01-23T11:14:24Z

As discussed on other Pull Requests, long-term support releases of RHEL/CentOS/derivates and Ubuntu still provide (and support) Python 2.7 no matter that it is not supported by the Python people anymore. This also includes Python 3.6 which is provided by long-term support releases of Linux distributions. This means that Python 2.7 and 3.6 will be in active use for 5-10 years more. Not everyone can install their own Python nor use Anaconda/Conda as installing packages not supported by the OS vendor then voids the warranty and support contracts with the OS vendor. It's okay to use PythonQt not shipping from the vendor but if you introduce your own Python installation/version then the vendor will disavow any support for anything breaking as they will blame interference with the system version. Hence when building Qt apps using PythonQt, one is stuck with the compiler, Qt version, and Python version provided by the OS vendor until the extended-extended EOL of the Linux distribution. From the developer point of view, this also means that security/stability can be delegated to the OS vendor and the developer do not need to provide security patches and maintenance fixes for Python, Qt, etc which they would need to do if they ship their own versions. It is the OS vendor's responsibility to ensure Python 2.7 and 3.6 are working on their distribution and is security and maintenance patched during the entire long-term support window.

build/python.prf

extensions/PythonQt_QtAll/PythonQt_QtAll.pro

generator/generator.pri

src/PythonQt.cpp

tests/PythonQtTestMain.cpp

src/src.pri

src/PythonQt.cpp

1. Fix failed tests count report 2. Support exact Python version match, add `--embed` flag for 3.8+ only 3. Code cleanup +4. Use canonical way to add RPATH, on GNU/Linux the Makefile is the same for projects with the TEMPLATE=app, and no redundant link flags for TEMPLATE=lib

mrbean-bremen

Thanks - this looks good to me now, though I would like somebody else to have another look.

* Add support for `pkg-config`. If PKGCONFIG is set, skip old-style lookup. Useful on GNU/Linux and on macOS GHA, when `python-config` returns incorrect linkage options with missing `-Ldirs` * Add macOS GHA CI

mrbean-bremen · 2023-01-26T20:04:00Z

.github/workflows/build.yml

+      uses: actions/upload-artifact@v3
+      with:
+        name: wrappers_macos${{ steps.versions.outputs.MACOS_VERSION_SHORT }}_qt${{ steps.versions.outputs.QT_VERSION_SHORT }}
+        path: generated_cpp


Ah, that's cool, thanks! I tried to get a Mac build working, but I lack experience with Mac builds and couldn't get Python to correctly link. Now only a Windows build is missing...

mrbean-bremen · 2023-01-27T06:46:49Z

@iakov - are you done here? If yes, I will wait a bit for somebody else to chime in, and merge, if nobody objects.

src/PythonQt.cpp

src/PythonQtPythonInclude.h

src/PythonQt.cpp

iakov · 2023-01-30T11:44:45Z

Added last cleanup as was requested. I'm done.

mrbean-bremen · 2023-01-30T12:20:03Z

Thanks a lot!

mrbean-bremen · 2023-05-24T09:01:27Z

src/PythonQtPythonInclude.h

+#ifdef _POSIX_C_SOURCE
+#  undef _POSIX_C_SOURCE
+#endif
+
+#ifdef _POSIX_THREADS
+#  undef _POSIX_THREADS
+#endif
+
+#ifdef _XOPEN_SOURCE
+#  undef _XOPEN_SOURCE
+#endif
+


@iakov - we have a problem with this code, as it undefines _POSIX_THREADS, which leads to errors due to missing defines in pythread.h. As far as I can see, _POSIX_THREADS is not defined in Python.h, it just is checked (in pythread.h) to see if POSIX threads are defined. It think it is defined in pthread.h or a related include. The same seems to be true for the other symbols.
I'm inclined to revert this specific change, though I may be misunderstanding something. Can you please elaborate on this?

I'll make a PR to revert this to discuss this.

- this has been introduced in MeVisLab#89 and breaks builds including "pythread.h"

- this has been introduced in #89 and breaks builds including "pythread.h" - fixes #103

iakov added 7 commits January 21, 2023 18:28

Unit tests and minor build improvements

ee8628e

* Parallel build * `make check` support * Fix `debug`/`release` builds

More warnings and nicer code

a203a42

* Force C++11 * Disable annoying warnings for deprecated declarations * Add -Wpedantic and even -Werror for src, but relaxe some warnings * Code cleanup for less warnings

Fix undefined behavior

bc4aa1e

* Introduce UBSan into CI * Fix UB with incorrect alignment. This is a dirty hotfix in the rxx_allocator.

Fix memory leak

7a1661a

Minor code improvements

8a0c4f5

Remove unused code and redundant ctors

Fix undefined behavour in union

d89535b

Missed this fix in #bc4aa1e

Better code with QT_NO_CAST_TO_ASCII

fa4a55b

But really QT_NO_CAST_FROM_ASCII can help prevent incorrect behavior on non-Latin1 input

iakov commented Jan 23, 2023

View reviewed changes

build/python.prf Outdated Show resolved Hide resolved

mrbean-bremen reviewed Jan 23, 2023

View reviewed changes

mrbean-bremen reviewed Jan 24, 2023

View reviewed changes

src/PythonQt.cpp Outdated Show resolved Hide resolved

mrbean-bremen approved these changes Jan 24, 2023

View reviewed changes

iakov added 2 commits January 25, 2023 21:34

Fixes for macOS build with clang

92c700e

Add pkg-config support

7e0687a

* Add support for `pkg-config`. If PKGCONFIG is set, skip old-style lookup. Useful on GNU/Linux and on macOS GHA, when `python-config` returns incorrect linkage options with missing `-Ldirs` * Add macOS GHA CI

mrbean-bremen reviewed Jan 26, 2023

View reviewed changes

usiems reviewed Jan 27, 2023

View reviewed changes

src/PythonQt.cpp Outdated Show resolved Hide resolved

src/PythonQtPythonInclude.h Outdated Show resolved Hide resolved

src/PythonQt.cpp Outdated Show resolved Hide resolved

Cleanup after review

6378df5

mrbean-bremen merged commit 1e794e5 into MeVisLab:master Jan 30, 2023

mrbean-bremen reviewed May 24, 2023

View reviewed changes

mrbean-bremen added a commit to mrbean-bremen/pythonqt that referenced this pull request May 24, 2023

Revert undefining some defines

615752c

- this has been introduced in MeVisLab#89 and breaks builds including "pythread.h"

mrbean-bremen mentioned this pull request May 24, 2023

Revert undefining some defines #103

Merged

mrbean-bremen added a commit to mrbean-bremen/pythonqt that referenced this pull request Jul 7, 2023

Revert undefining some defines

9a794bf

- this has been introduced in MeVisLab#89 and breaks builds including "pythread.h"

mrbean-bremen added a commit that referenced this pull request Jul 8, 2023

Revert undefining some defines (#103)

30ca585

- this has been introduced in #89 and breaks builds including "pythread.h" - fixes #103

iakov deleted the pr/cumulative_patchwork branch October 12, 2023 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cumulative patchwork from my repo #89

Cumulative patchwork from my repo #89

Uh oh!

iakov commented Jan 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

he-hesce commented Jan 23, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrbean-bremen left a comment

Uh oh!

mrbean-bremen Jan 26, 2023

Uh oh!

mrbean-bremen commented Jan 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iakov commented Jan 30, 2023

Uh oh!

mrbean-bremen commented Jan 30, 2023

Uh oh!

mrbean-bremen May 24, 2023 •

edited

Loading

Uh oh!

mrbean-bremen May 24, 2023

Uh oh!

Uh oh!

Cumulative patchwork from my repo #89

Cumulative patchwork from my repo #89

Uh oh!

Conversation

iakov commented Jan 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

he-hesce commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrbean-bremen left a comment

Choose a reason for hiding this comment

Uh oh!

mrbean-bremen Jan 26, 2023

Choose a reason for hiding this comment

Uh oh!

mrbean-bremen commented Jan 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iakov commented Jan 30, 2023

Uh oh!

mrbean-bremen commented Jan 30, 2023

Uh oh!

mrbean-bremen May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrbean-bremen May 24, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iakov commented Jan 21, 2023 •

edited

Loading

he-hesce commented Jan 23, 2023 •

edited

Loading

mrbean-bremen May 24, 2023 •

edited

Loading