-
Notifications
You must be signed in to change notification settings - Fork 61
bug: invalid key: conceal_lines #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You must have an old build of |
I think you could do a check to see if conceal_lines exists. if it does not we could polyfill it. What do you think @MeanderingProgrammer ? I can also confirm that it is an older version of nvim. For those of using brew you need to:
|
Any suggestion on how, that's kind of what the version checks were meant to catch but there are these edge cases. I can wrap the
I don't think there would be a way to polyfill it, prior to the vertical conceal logic added by |
Oh, I think you are right on all accounts here. The best solution I think here may be to add a "if you get this" then do this to the installation guide in the readme. since this is used in avante I think it should be added there too. But all of that is just for the sake of completeness because if someone has that issue and knows how to look they will find this. Although I dont know how true that is with all of the new "vibe coders" out there right now. |
## Details Related to issues like #382 We use a version check like `vim.fn.has('nvim-0.11') == 1` before adding any `extmarks` that use version specific options like `conceal_lines`. By doing this we avoid ever getting to the API call that adds the marks and can add fallback behavior for certain decorations like code borders. However this version check has to make the assumption that the user has all the features of the released version, which should be safe for most people. However anyone using a dev version could have built it at a time where the version check passes but before that feature was introduced. This should be somewhat rare as it relies on someone having a dev build and not upgrading when a release occurs. In the event of an error we use `vim.notify_once` to inform the user that they should update their build or switch to the released version while not spamming errors at them. Minor other changes: - use `vim.o` to get options instead of `nvim_get_option_value` - update `colorcolumn` suggestions to use option value
Decided to use the |
Neovim version (nvim -v)
v0.11.0-dev-1517+ga37784ad83
Neovim distribution
N/A
Operating system
MacOS
Terminal emulator / GUI
ghostty
Describe the bug
Error executing vim.schedule lua callback: ...ender-markdown.nvim/lua/render-markdown/core/extmark.lua:37: invalid key: conceal_lines
stack traceback:
[C]: in function 'nvim_buf_set_extmark'
...ender-markdown.nvim/lua/render-markdown/core/extmark.lua:37: in function 'show'
...azy/render-markdown.nvim/lua/render-markdown/core/ui.lua:150: in function 'run_update'
...azy/render-markdown.nvim/lua/render-markdown/core/ui.lua:90: in function <...azy/render-markdown.nvim/lua/render-markdown/core/ui.lua:89>
Expected behavior
I have tried removing and reinstalling render-markdown.
Healthcheck output
Plugin configuration
Plugin error log
Confirmations
Additional information
No response
The text was updated successfully, but these errors were encountered: