test: migrate queue personal sign spec to ts and POM #33451

pnarayanaswamy · 2025-06-03T15:14:06Z

Description

Moves the personal sign queueing test to the confirmations/signatures already existing personal sign spec. Migrates the test to POM and ts.

Related issues

Fixes: MMQA-637

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-06-03T15:14:20Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-06-03T15:28:30Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

metamaskbot · 2025-06-03T15:37:50Z

Builds ready [dc6af92]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1236 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1236	1119	1392	60	1283	1338
			load	1070	975	1215	54	1116	1155
			domContentLoaded	1063	971	1206	54	1110	1149
			domInteractive	17	13	34	5	16	32
			firstPaint	779	80	1214	407	1094	1156
			backgroundConnect	7	4	29	3	8	11
			firstReactRender	20	15	43	4	21	28
			getState	14	6	59	9	19	31
			initialActions	0	0	1	0	0	1
			loadScripts	809	718	950	52	855	894
			setupStore	8	5	26	3	8	12
	Webpack	Home	uiStartup	2137	1749	2653	218	2291	2506
			load	1656	1355	2024	171	1777	1957
			domContentLoaded	1650	1351	2016	170	1768	1953
			domInteractive	15	11	63	9	13	44
			firstPaint	180	65	664	91	204	307
			backgroundConnect	27	10	246	28	28	46
			firstReactRender	144	43	352	104	228	346
			getState	14	4	338	33	13	19
			initialActions	5	1	257	25	3	5
			loadScripts	1646	1349	2006	168	1764	1948
			setupStore	26	7	313	52	19	40
Firefox	Browserify	Home	uiStartup	1367	1163	1711	121	1452	1584
			load	1213	1024	1559	110	1275	1439
			domContentLoaded	1213	1024	1558	110	1275	1439
			domInteractive	98	33	288	42	104	189
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	181	18	20	40
			firstReactRender	23	20	53	4	23	28
			getState	11	4	174	23	8	26
			initialActions	0	0	1	0	0	1
			loadScripts	1194	1010	1546	109	1259	1423
			setupStore	9	4	75	11	8	20
	Webpack	Home	uiStartup	1585	1336	2165	178	1669	1911
			load	1377	1156	1958	163	1460	1681
			domContentLoaded	1377	1156	1958	163	1460	1681
			domInteractive	83	35	516	52	84	153
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	61	7	22	37
			firstReactRender	41	27	51	5	43	49
			getState	12	4	255	25	10	21
			initialActions	0	0	2	1	1	1
			loadScripts	1359	1141	1932	163	1444	1667
			setupStore	9	5	70	8	8	19

Benchmark value 1237 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 2507 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1681 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1681 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1667 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 10ms | Sum of p95 exceeds: 134ms
Sum of all benchmark exceeds: 144ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -183 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-04T07:31:54Z

Builds ready [71fb820]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1280 ± 275 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1280	1087	3703	275	1284	1453
			load	1111	976	2993	222	1121	1269
			domContentLoaded	1104	971	2979	221	1115	1262
			domInteractive	19	14	111	11	18	31
			firstPaint	733	134	1281	428	1094	1183
			backgroundConnect	8	5	33	5	8	23
			firstReactRender	24	14	119	15	23	43
			getState	14	6	53	9	19	32
			initialActions	0	0	3	0	0	1
			loadScripts	847	727	2311	187	861	1005
			setupStore	9	5	28	4	9	19
	Webpack	Home	uiStartup	2067	1589	2553	232	2231	2435
			load	1607	1239	2056	178	1708	1898
			domContentLoaded	1601	1235	2051	177	1704	1888
			domInteractive	15	11	60	9	13	41
			firstPaint	165	62	534	68	185	292
			backgroundConnect	24	10	226	22	24	43
			firstReactRender	136	43	366	102	140	341
			getState	13	4	318	31	12	22
			initialActions	3	1	6	1	3	4
			loadScripts	1596	1233	1946	171	1703	1845
			setupStore	25	6	314	56	16	55
Firefox	Browserify	Home	uiStartup	1371	1157	1759	128	1430	1634
			load	1212	1034	1580	109	1254	1420
			domContentLoaded	1212	1034	1579	108	1253	1420
			domInteractive	95	35	186	26	104	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	114	15	22	50
			firstReactRender	24	21	31	2	25	29
			getState	9	5	77	9	8	14
			initialActions	0	0	1	0	0	1
			loadScripts	1192	1019	1559	106	1233	1385
			setupStore	10	4	191	25	7	12
	Webpack	Home	uiStartup	1552	1338	2062	163	1644	1992
			load	1346	1154	1828	144	1423	1653
			domContentLoaded	1346	1153	1828	144	1423	1652
			domInteractive	81	36	362	44	82	101
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	58	6	22	31
			firstReactRender	41	31	69	5	43	48
			getState	15	4	252	40	9	30
			initialActions	0	0	1	0	1	1
			loadScripts	1327	1140	1805	144	1407	1634
			setupStore	8	5	26	3	8	12

Benchmark value 1280 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1112 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1105 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 848 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1454 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1269 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1263 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 1005 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1992 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1634 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 158ms | Sum of p95 exceeds: 388ms
Sum of all benchmark exceeds: 546ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-05T10:19:47Z

Builds ready [c70b766]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1209 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1209	1096	1503	64	1249	1328
			load	1049	928	1334	60	1074	1155
			domContentLoaded	1043	924	1324	60	1067	1148
			domInteractive	16	13	29	4	16	27
			firstPaint	718	86	1330	418	1057	1147
			backgroundConnect	7	4	22	3	7	11
			firstReactRender	20	15	37	4	20	26
			getState	14	6	41	8	19	30
			initialActions	0	0	1	0	0	1
			loadScripts	797	685	1046	57	819	903
			setupStore	8	5	13	2	8	12
	Webpack	Home	uiStartup	2063	1571	2564	245	2233	2470
			load	1603	1243	1968	188	1719	1910
			domContentLoaded	1596	1239	1957	186	1710	1895
			domInteractive	15	11	68	9	13	41
			firstPaint	158	59	331	57	181	282
			backgroundConnect	22	9	51	8	25	37
			firstReactRender	152	43	450	117	304	339
			getState	11	4	169	17	11	22
			initialActions	2	1	5	1	3	4
			loadScripts	1593	1238	1946	185	1708	1885
			setupStore	25	6	305	56	15	56
Firefox	Browserify	Home	uiStartup	1387	1200	2006	140	1449	1611
			load	1225	1058	1811	125	1272	1425
			domContentLoaded	1225	1057	1811	125	1272	1425
			domInteractive	101	34	425	45	112	156
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	13	279	29	23	50
			firstReactRender	24	21	39	3	25	31
			getState	13	4	185	28	8	17
			initialActions	0	0	1	0	0	1
			loadScripts	1202	1039	1796	115	1254	1398
			setupStore	7	4	61	6	7	12
	Webpack	Home	uiStartup	1667	1331	2549	202	1791	1993
			load	1443	1165	1970	167	1570	1753
			domContentLoaded	1443	1165	1969	167	1568	1753
			domInteractive	82	43	272	27	91	129
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	16	284	36	25	35
			firstReactRender	44	29	63	6	49	54
			getState	12	5	203	25	10	27
			initialActions	1	0	2	1	1	1
			loadScripts	1417	1149	1780	154	1550	1693
			setupStore	10	5	76	8	9	21

Benchmark value 2471 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1667 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1443 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1443 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1418 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1993 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1753 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1753 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 1693 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 247ms | Sum of p95 exceeds: 328ms
Sum of all benchmark exceeds: 575ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

test:migrate queue personal sign spec to ts and POM

dc6af92

metamaskbot added the team-qa QA team label Jun 3, 2025

Merge branch 'main' into pom-personal-sign

71fb820

OGPoyraz approved these changes Jun 5, 2025

View reviewed changes

Merge branch 'main' into pom-personal-sign

c70b766

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: migrate queue personal sign spec to ts and POM #33451

test: migrate queue personal sign spec to ts and POM #33451

pnarayanaswamy commented Jun 3, 2025 •

edited by jira bot

Loading

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

Uh oh!

test: migrate queue personal sign spec to ts and POM #33451

Are you sure you want to change the base?

test: migrate queue personal sign spec to ts and POM #33451

Conversation

pnarayanaswamy commented Jun 3, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

Uh oh!

pnarayanaswamy commented Jun 3, 2025 •

edited by jira bot

Loading