feat: removed feature flag for gns #33459

NidhiKJha · 2025-06-03T19:22:19Z

This PR is to remove GNS feature flag

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-06-03T19:24:32Z

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (1 files, +5 -1)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 assets/
      - 📁 token-cell/
        
        📁 __snapshots__/
        
        📄 token-cell.test.tsx.snap +5 -1

🖥️ @MetaMask/wallet-ux (7 files, +253 -378)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-picker/
      - 📁 __snapshots__/
        
        📄 account-picker.test.js.snap +1 -12
        
        📄 account-picker.js +2 -25
        
        📄 account-picker.test.js +0 -12
    - 📁 address-list-item/
      - 📁 __snapshots__/
        
        📄 address-list-item.test.tsx.snap +138 -87
        
        📄 address-list-item.tsx +13 -26
    - 📁 app-header/
      - 📁 __snapshots__/
        
        📄 app-header.test.js.snap +79 -110
        
        📄 app-header-unlocked-content.tsx +20 -106

metamaskbot · 2025-06-03T19:44:54Z

Builds ready [3ad8443]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1248 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1248	1123	1510	72	1296	1385
			load	1079	958	1325	72	1133	1191
			domContentLoaded	1072	948	1320	72	1126	1186
			domInteractive	17	13	34	4	17	29
			firstPaint	709	89	1256	441	1093	1193
			backgroundConnect	9	4	37	6	8	23
			firstReactRender	18	13	40	4	18	24
			getState	15	6	79	9	20	29
			initialActions	0	0	1	0	0	1
			loadScripts	822	700	1059	70	870	934
			setupStore	8	5	26	3	8	13
	Webpack	Home	uiStartup	2046	1567	2659	243	2195	2463
			load	1594	1222	2024	200	1736	1993
			domContentLoaded	1585	1216	2017	197	1723	1981
			domInteractive	16	11	79	11	13	46
			firstPaint	160	63	362	61	169	297
			backgroundConnect	32	10	430	57	25	55
			firstReactRender	127	40	361	104	112	352
			getState	10	4	31	4	12	22
			initialActions	3	1	7	1	3	4
			loadScripts	1582	1214	2016	196	1721	1971
			setupStore	28	6	316	64	16	294
Firefox	Browserify	Home	uiStartup	1374	1161	2070	131	1436	1606
			load	1218	1044	1627	110	1284	1435
			domContentLoaded	1218	1044	1627	110	1283	1435
			domInteractive	98	36	361	35	108	140
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	14	341	34	22	48
			firstReactRender	22	18	30	3	22	27
			getState	8	4	35	4	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1197	1030	1610	105	1262	1400
			setupStore	9	4	78	10	7	22
	Webpack	Home	uiStartup	1553	1358	2082	157	1660	1859
			load	1354	1171	1878	147	1452	1627
			domContentLoaded	1354	1170	1878	147	1452	1627
			domInteractive	75	33	337	30	78	103
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	78	8	22	30
			firstReactRender	38	25	48	4	41	46
			getState	10	4	84	9	9	27
			initialActions	1	0	1	0	1	1
			loadScripts	1335	1155	1859	146	1430	1602
			setupStore	9	5	83	8	8	14

Benchmark value 1249 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1385 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1192 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1186 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1193 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2463 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1971 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 294 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 38ms | Sum of p95 exceeds: 285ms
Sum of all benchmark exceeds: 323ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -23.61 KiB (-0.44%)
ui: 2.16 KiB (0.03%)
common: -7.79 KiB (-0.09%)

metamaskbot · 2025-06-05T11:20:19Z

Builds ready [5baad98]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1202 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1202	1090	1459	71	1232	1359
			load	1041	920	1257	70	1070	1202
			domContentLoaded	1034	911	1253	71	1063	1193
			domInteractive	16	13	37	5	16	29
			firstPaint	713	67	1224	415	1054	1194
			backgroundConnect	8	4	29	5	8	24
			firstReactRender	18	12	43	5	18	31
			getState	14	5	57	8	19	26
			initialActions	0	0	1	0	0	1
			loadScripts	787	669	972	69	815	944
			setupStore	8	5	29	3	8	17
	Webpack	Home	uiStartup	2062	1650	2559	212	2209	2470
			load	1614	1293	1963	166	1725	1904
			domContentLoaded	1608	1289	1950	164	1720	1900
			domInteractive	16	11	60	10	13	46
			firstPaint	166	64	607	75	198	305
			backgroundConnect	25	12	273	26	26	39
			firstReactRender	111	39	354	93	95	344
			getState	11	4	46	7	12	25
			initialActions	3	1	7	1	3	4
			loadScripts	1605	1288	1939	163	1716	1898
			setupStore	32	6	313	70	18	302
Firefox	Browserify	Home	uiStartup	1362	1174	1719	113	1425	1648
			load	1210	1015	1524	103	1283	1412
			domContentLoaded	1210	1014	1524	103	1283	1411
			domInteractive	100	35	417	40	109	152
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	170	16	21	31
			firstReactRender	22	19	83	6	22	26
			getState	11	5	215	24	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1191	1004	1502	101	1262	1394
			setupStore	7	4	52	7	6	21
	Webpack	Home	uiStartup	2131	1640	3308	355	2349	2840
			load	1883	1360	2998	337	2058	2501
			domContentLoaded	1883	1360	2998	337	2058	2501
			domInteractive	107	49	409	46	114	163
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	17	72	8	29	43
			firstReactRender	51	37	99	11	54	78
			getState	10	6	34	5	11	23
			initialActions	1	0	2	1	1	1
			loadScripts	1860	1335	2972	336	2030	2480
			setupStore	10	6	21	3	11	18

cc: @HowardBraham
Benchmark value 1203 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1193 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1195 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2471 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 302 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 2131 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1884 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1884 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1861 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2840 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 2501 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 2501 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 163 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 78 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 2480 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 2048ms | Sum of p95 exceeds: 3778ms
Sum of all benchmark exceeds: 5826ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -22.65 KiB (-0.42%)
ui: -888 Bytes (-0.01%)
common: -7.9 KiB (-0.09%)

metamaskbot · 2025-06-05T12:29:43Z

Builds ready [8561168]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1219 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1219	1095	1465	74	1261	1382
			load	1059	948	1262	66	1105	1172
			domContentLoaded	1053	937	1256	66	1100	1166
			domInteractive	16	13	39	5	16	29
			firstPaint	700	69	1211	436	1099	1143
			backgroundConnect	7	4	34	4	8	12
			firstReactRender	17	13	31	3	18	22
			getState	14	6	59	8	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	808	691	1008	65	854	912
			setupStore	8	5	16	2	8	11
	Webpack	Home	uiStartup	2087	1643	2607	220	2237	2470
			load	1636	1301	1980	176	1773	1928
			domContentLoaded	1629	1297	1963	175	1766	1919
			domInteractive	15	11	52	9	13	40
			firstPaint	157	66	304	49	192	244
			backgroundConnect	23	10	56	10	27	50
			firstReactRender	123	40	371	105	120	341
			getState	10	4	45	6	12	23
			initialActions	3	1	7	1	3	4
			loadScripts	1626	1296	1952	174	1764	1918
			setupStore	65	7	320	111	23	313
Firefox	Browserify	Home	uiStartup	1335	1160	2219	143	1392	1559
			load	1197	1040	2075	141	1260	1414
			domContentLoaded	1197	1040	2075	141	1259	1414
			domInteractive	110	34	1078	104	109	161
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	42	5	20	28
			firstReactRender	20	18	28	2	21	25
			getState	7	4	75	7	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1180	1025	2058	140	1242	1398
			setupStore	6	4	24	3	6	11
	Webpack	Home	uiStartup	1629	1360	2088	162	1707	2010
			load	1425	1184	1906	156	1515	1803
			domContentLoaded	1425	1184	1905	156	1514	1802
			domInteractive	81	49	287	27	86	117
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	245	23	23	42
			firstReactRender	40	25	50	4	43	47
			getState	11	5	123	13	9	28
			initialActions	0	0	1	0	1	1
			loadScripts	1404	1169	1887	154	1494	1783
			setupStore	10	5	268	27	8	10

Benchmark value 1382 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 66 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2471 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 313 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 1629 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1426 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1425 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1404 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2010 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1803 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1802 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1783 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 186ms | Sum of p95 exceeds: 795ms
Sum of all benchmark exceeds: 981ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -132.95 KiB (-2.49%)
ui: 12.04 KiB (0.17%)
common: -14.44 KiB (-0.17%)

metamaskbot · 2025-06-07T13:38:03Z

Builds ready [d446ed8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1188 ± 54 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1188	1092	1313	54	1221	1298
			load	1032	937	1141	47	1062	1105
			domContentLoaded	1025	929	1137	49	1056	1100
			domInteractive	16	13	31	4	16	29
			firstPaint	666	129	1126	406	1036	1105
			backgroundConnect	8	4	29	5	8	23
			firstReactRender	17	13	40	3	17	21
			getState	14	6	40	8	20	27
			initialActions	0	0	10	1	0	1
			loadScripts	783	685	896	49	817	858
			setupStore	8	5	28	3	8	14
	Webpack	Home	uiStartup	2059	1582	2530	238	2205	2444
			load	1626	1256	1918	190	1733	1901
			domContentLoaded	1621	1252	1913	189	1729	1897
			domInteractive	14	11	47	7	13	35
			firstPaint	156	63	324	60	199	267
			backgroundConnect	21	12	36	6	24	34
			firstReactRender	96	41	345	73	88	315
			getState	19	4	309	51	12	21
			initialActions	3	1	5	1	3	4
			loadScripts	1618	1250	1911	188	1727	1889
			setupStore	42	7	311	87	16	303
Firefox	Browserify	Home	uiStartup	1309	1202	1648	88	1359	1531
			load	1161	1017	1415	76	1221	1316
			domContentLoaded	1161	1016	1414	76	1221	1315
			domInteractive	91	33	207	27	98	135
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	59	9	21	48
			firstReactRender	22	19	53	5	21	26
			getState	11	4	171	23	8	16
			initialActions	0	0	1	0	0	1
			loadScripts	1142	1002	1400	78	1203	1298
			setupStore	7	4	33	4	7	12
	Webpack	Home	uiStartup	1490	1317	1787	107	1553	1714
			load	1297	1151	1544	99	1354	1495
			domContentLoaded	1296	1151	1544	99	1354	1495
			domInteractive	76	54	265	24	78	115
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	37	3	21	26
			firstReactRender	38	26	66	5	40	46
			getState	11	4	246	25	8	30
			initialActions	0	0	2	1	1	1
			loadScripts	1279	1133	1526	99	1336	1476
			setupStore	7	5	28	3	8	12

Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 43 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 303 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Sum of mean exceeds: 12ms | Sum of p95 exceeds: 244ms
Sum of all benchmark exceeds: 256ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: -1.97 KiB (-0.03%)
common: 112 Bytes (0%)

richardcacho

~~done/review~~

metamaskbot · 2025-06-07T21:09:58Z

Builds ready [b738456]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1213 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1213	1085	1450	66	1250	1351
			load	1047	946	1250	62	1081	1159
			domContentLoaded	1040	929	1245	63	1075	1151
			domInteractive	17	13	34	4	16	28
			firstPaint	724	138	1231	412	1061	1150
			backgroundConnect	8	4	29	5	8	22
			firstReactRender	17	13	29	2	18	21
			getState	14	6	49	9	19	31
			initialActions	0	0	1	0	0	1
			loadScripts	794	691	984	62	827	901
			setupStore	8	5	15	2	8	14
	Webpack	Home	uiStartup	2016	1567	2514	253	2219	2414
			load	1564	1252	1919	187	1704	1844
			domContentLoaded	1559	1248	1913	186	1699	1836
			domInteractive	15	11	45	7	13	38
			firstPaint	161	64	559	74	191	282
			backgroundConnect	22	10	263	25	23	32
			firstReactRender	122	40	354	99	120	335
			getState	16	4	310	42	11	22
			initialActions	8	1	305	42	3	4
			loadScripts	1556	1246	1911	184	1697	1825
			setupStore	24	7	308	55	16	23
Firefox	Browserify	Home	uiStartup	1326	1174	1638	96	1376	1535
			load	1178	1017	1442	85	1238	1345
			domContentLoaded	1178	1017	1442	85	1238	1345
			domInteractive	100	34	348	42	103	171
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	86	9	19	28
			firstReactRender	20	18	28	2	21	26
			getState	11	4	183	26	8	13
			initialActions	0	0	1	0	0	1
			loadScripts	1161	1004	1423	83	1222	1321
			setupStore	7	4	71	8	6	15
	Webpack	Home	uiStartup	1543	1370	1967	124	1610	1787
			load	1342	1185	1725	114	1414	1571
			domContentLoaded	1342	1185	1725	114	1414	1570
			domInteractive	80	55	174	22	88	126
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	56	8	23	40
			firstReactRender	38	28	45	3	40	43
			getState	9	5	32	5	9	26
			initialActions	1	0	2	1	1	1
			loadScripts	1323	1166	1701	114	1397	1555
			setupStore	10	5	255	25	8	18

Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Sum of mean exceeds: 3ms | Sum of p95 exceeds: 5ms
Sum of all benchmark exceeds: 8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -3.78 KiB (-0.05%)
common: -8 Bytes (0%)

metamaskbot · 2025-06-07T22:11:37Z

Builds ready [d51fb64]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1217 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1217	1097	1568	74	1264	1335
			load	1055	936	1357	66	1101	1156
			domContentLoaded	1048	928	1352	67	1093	1151
			domInteractive	19	13	233	23	16	31
			firstPaint	741	76	1377	418	1094	1134
			backgroundConnect	8	4	32	5	8	24
			firstReactRender	17	14	24	2	18	21
			getState	15	6	36	8	21	30
			initialActions	0	0	1	0	0	0
			loadScripts	806	687	1089	65	851	905
			setupStore	8	5	19	2	9	13
	Webpack	Home	uiStartup	2108	1592	2538	241	2299	2493
			load	1642	1247	2004	186	1782	1921
			domContentLoaded	1636	1242	1994	185	1774	1911
			domInteractive	15	11	54	8	13	37
			firstPaint	169	64	541	70	188	306
			backgroundConnect	21	13	53	6	25	34
			firstReactRender	133	42	358	107	124	340
			getState	13	4	265	26	12	17
			initialActions	3	1	7	1	3	4
			loadScripts	1633	1241	1984	183	1771	1900
			setupStore	46	7	326	91	18	310
Firefox	Browserify	Home	uiStartup	1330	1160	1696	109	1388	1579
			load	1180	1039	1480	90	1229	1367
			domContentLoaded	1180	1039	1480	90	1229	1367
			domInteractive	99	34	347	44	107	196
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	12	132	14	21	31
			firstReactRender	21	18	49	4	21	27
			getState	9	4	154	17	8	11
			initialActions	0	0	2	0	0	1
			loadScripts	1162	1025	1466	89	1214	1352
			setupStore	9	4	178	18	7	11
	Webpack	Home	uiStartup	1543	1370	1934	108	1625	1710
			load	1342	1192	1714	107	1426	1532
			domContentLoaded	1342	1192	1713	107	1426	1531
			domInteractive	77	31	185	18	81	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	237	22	24	35
			firstReactRender	39	27	61	4	41	45
			getState	9	5	30	5	9	23
			initialActions	1	0	2	1	1	1
			loadScripts	1321	1175	1699	105	1404	1498
			setupStore	9	5	68	7	8	20

Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 47 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2493 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 310 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 196 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 291ms
Sum of all benchmark exceeds: 307ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -3.75 KiB (-0.05%)
common: -8 Bytes (0%)

removed feature flag for gns

3ad8443

NidhiKJha requested a review from a team as a code owner June 3, 2025 19:22

metamaskbot added team-wallet-ux INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 3, 2025

removed unified swap flag

5baad98

NidhiKJha added 2 commits June 5, 2025 13:04

lint-fix

a903516

fixed tests for icon-button

8561168

NidhiKJha and others added 3 commits June 7, 2025 14:15

Merge branch 'main' into gns-feature-flag-removal

d446ed8

lintfix

47322e5

header fix

8987752

jest update

eaad3bb

NidhiKJha requested review from a team as code owners June 7, 2025 20:29

storybook fixes

b738456

MetaMask deleted a comment from richardcacho Jun 7, 2025

richardcacho reviewed Jun 7, 2025

View reviewed changes

NidhiKJha added 2 commits June 7, 2025 22:27

app header test update

3a61226

jest update accounts

d51fb64

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: removed feature flag for gns #33459

feat: removed feature flag for gns #33459

NidhiKJha commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

richardcacho left a comment

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

Uh oh!

feat: removed feature flag for gns #33459

Are you sure you want to change the base?

feat: removed feature flag for gns #33459

Conversation

NidhiKJha commented Jun 3, 2025

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

richardcacho left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

Uh oh!

metamaskbot commented Jun 3, 2025 •

edited

Loading