Flaky vault #33460

davidmurdoch · 2025-06-03T19:23:55Z

Description

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-06-03T19:24:20Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-06-03T19:47:46Z

Builds ready [99aca51]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1206 ± 81 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1206	1090	1682	81	1244	1338
			load	1033	884	1530	84	1072	1149
			domContentLoaded	1025	878	1522	85	1066	1144
			domInteractive	16	13	61	6	15	28
			firstPaint	691	85	1263	414	1047	1121
			backgroundConnect	8	4	92	9	8	14
			firstReactRender	23	16	130	15	20	50
			getState	14	6	71	9	20	29
			initialActions	0	0	1	0	0	1
			loadScripts	775	643	996	68	823	889
			setupStore	9	5	48	5	8	18
	Webpack	Home	uiStartup	2074	1655	2572	242	2237	2474
			load	1631	1290	1961	198	1779	1924
			domContentLoaded	1625	1287	1957	197	1775	1919
			domInteractive	16	11	57	10	13	45
			firstPaint	159	58	359	62	186	284
			backgroundConnect	24	9	354	34	24	37
			firstReactRender	136	42	368	108	144	343
			getState	9	4	33	4	10	16
			initialActions	3	1	5	1	3	4
			loadScripts	1622	1285	1947	196	1774	1915
			setupStore	19	7	304	40	15	28
Firefox	Browserify	Home	uiStartup	1355	1151	1733	119	1427	1595
			load	1197	1028	1571	105	1253	1412
			domContentLoaded	1196	1028	1571	105	1253	1412
			domInteractive	93	37	183	25	105	138
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	12	184	29	24	107
			firstReactRender	23	20	34	2	24	29
			getState	10	4	344	34	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1173	1015	1557	104	1225	1358
			setupStore	8	4	73	9	6	11
	Webpack	Home	uiStartup	1584	1344	2195	176	1658	2012
			load	1378	1175	1938	167	1451	1807
			domContentLoaded	1378	1175	1938	167	1450	1807
			domInteractive	77	53	142	16	81	121
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	100	11	24	37
			firstReactRender	41	28	53	4	44	48
			getState	9	5	31	5	9	22
			initialActions	0	0	2	1	1	1
			loadScripts	1358	1160	1917	166	1418	1790
			setupStore	10	5	211	21	8	18

Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 50 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2475 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 107 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2012 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1807 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1807 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1790 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 595ms
Sum of all benchmark exceeds: 603ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -23.61 KiB (-0.44%)
ui: 2.65 KiB (0.04%)
common: -7.9 KiB (-0.09%)

metamaskbot · 2025-06-03T20:54:18Z

Builds ready [7fd5e07]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 81 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1220	1083	1437	81	1275	1382
			load	1064	930	1259	78	1113	1230
			domContentLoaded	1057	925	1249	78	1104	1222
			domInteractive	16	13	41	5	16	30
			firstPaint	792	102	1255	406	1082	1212
			backgroundConnect	8	4	32	4	8	17
			firstReactRender	21	16	45	6	20	38
			getState	13	6	27	6	18	23
			initialActions	0	0	1	0	0	1
			loadScripts	811	690	1005	77	855	978
			setupStore	8	5	24	3	8	12
	Webpack	Home	uiStartup	2180	1749	2705	232	2332	2621
			load	1712	1355	2061	188	1835	2005
			domContentLoaded	1705	1351	2051	187	1831	1995
			domInteractive	17	11	86	13	14	53
			firstPaint	157	69	375	58	176	279
			backgroundConnect	23	13	67	8	25	39
			firstReactRender	140	44	372	108	191	355
			getState	10	4	43	5	12	19
			initialActions	6	1	318	31	3	5
			loadScripts	1702	1350	2040	185	1829	1994
			setupStore	26	7	308	56	18	56
Firefox	Browserify	Home	uiStartup	1384	1160	1855	120	1457	1618
			load	1223	1033	1521	103	1279	1426
			domContentLoaded	1223	1033	1521	103	1279	1426
			domInteractive	101	36	372	39	111	149
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	122	14	21	49
			firstReactRender	24	21	33	3	24	31
			getState	12	5	204	26	8	37
			initialActions	0	0	1	0	0	1
			loadScripts	1204	1020	1493	103	1264	1411
			setupStore	9	4	241	24	7	12
	Webpack	Home	uiStartup	1596	1388	2188	170	1697	1961
			load	1376	1181	1793	146	1489	1726
			domContentLoaded	1376	1180	1793	146	1489	1726
			domInteractive	76	34	144	17	82	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	144	14	24	36
			firstReactRender	43	33	52	4	45	49
			getState	16	5	266	38	10	30
			initialActions	1	0	2	1	1	1
			loadScripts	1354	1164	1772	145	1463	1711
			setupStore	11	5	260	25	9	13

Benchmark value 1383 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1230 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1222 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1212 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 979 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 1712 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1706 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1703 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2622 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1994 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1961 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1726 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1726 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1711 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 15ms | Sum of p95 exceeds: 615ms
Sum of all benchmark exceeds: 630ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -23.61 KiB (-0.44%)
ui: 2.7 KiB (0.04%)
common: -7.9 KiB (-0.09%)

metamaskbot · 2025-06-03T21:40:37Z

Builds ready [6eb3793]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1228 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1228	1117	1359	56	1270	1322
			load	1061	960	1189	54	1104	1155
			domContentLoaded	1053	939	1183	55	1098	1144
			domInteractive	16	13	35	4	16	29
			firstPaint	713	73	1190	432	1074	1145
			backgroundConnect	9	4	34	6	9	27
			firstReactRender	21	16	42	5	21	35
			getState	14	5	42	8	20	31
			initialActions	0	0	1	0	0	1
			loadScripts	804	694	928	55	853	888
			setupStore	8	5	16	2	8	12
	Webpack	Home	uiStartup	2062	1585	2698	240	2201	2503
			load	1609	1260	2039	187	1732	1956
			domContentLoaded	1603	1256	2016	185	1727	1942
			domInteractive	16	11	105	13	13	52
			firstPaint	163	62	424	59	204	265
			backgroundConnect	24	12	324	32	23	41
			firstReactRender	130	42	359	106	113	356
			getState	13	4	307	30	11	20
			initialActions	3	2	5	1	3	4
			loadScripts	1600	1254	2005	184	1726	1931
			setupStore	31	7	313	68	17	303
Firefox	Browserify	Home	uiStartup	1397	1215	2064	130	1447	1642
			load	1233	1080	1778	117	1270	1471
			domContentLoaded	1232	1080	1778	117	1270	1471
			domInteractive	98	34	421	41	109	144
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	56	7	22	34
			firstReactRender	25	21	37	3	26	31
			getState	12	5	184	26	8	30
			initialActions	0	0	1	0	0	1
			loadScripts	1214	1061	1757	116	1252	1449
			setupStore	7	4	59	7	7	15
	Webpack	Home	uiStartup	1565	1357	2111	160	1662	1918
			load	1360	1173	1913	159	1456	1718
			domContentLoaded	1360	1173	1912	159	1456	1718
			domInteractive	76	37	144	17	80	114
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	54	5	21	25
			firstReactRender	41	28	50	4	44	49
			getState	11	5	252	25	9	29
			initialActions	1	0	2	1	1	1
			loadScripts	1343	1158	1892	160	1437	1701
			setupStore	7	5	24	2	8	10

Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2503 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 303 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1701 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 5ms | Sum of p95 exceeds: 489ms
Sum of all benchmark exceeds: 494ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -23.61 KiB (-0.44%)
ui: 2.7 KiB (0.04%)
common: -7.9 KiB (-0.09%)

test/e2e/tests/vault-corruption/vault-corruption.spec.ts

metamaskbot · 2025-06-04T21:59:38Z

Builds ready [65df251]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1232 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1232	1114	1481	68	1283	1371
			load	1067	952	1279	61	1106	1175
			domContentLoaded	1060	948	1248	59	1098	1166
			domInteractive	17	14	45	6	16	31
			firstPaint	772	132	1263	419	1097	1160
			backgroundConnect	8	4	27	4	8	16
			firstReactRender	20	16	35	3	20	26
			getState	15	6	48	8	20	29
			initialActions	0	0	1	0	0	0
			loadScripts	808	709	980	58	842	905
			setupStore	8	5	50	5	8	12
	Webpack	Home	uiStartup	2021	1576	2543	248	2204	2471
			load	1586	1249	1927	195	1731	1901
			domContentLoaded	1580	1246	1921	194	1723	1897
			domInteractive	15	11	52	9	13	44
			firstPaint	166	63	574	71	188	300
			backgroundConnect	21	10	59	8	24	37
			firstReactRender	143	43	366	115	304	355
			getState	13	4	317	31	11	29
			initialActions	3	1	6	1	3	4
			loadScripts	1578	1244	1920	193	1721	1887
			setupStore	19	6	315	42	16	26
Firefox	Browserify	Home	uiStartup	1359	1148	1983	124	1416	1564
			load	1209	1022	1804	119	1265	1415
			domContentLoaded	1208	1021	1803	119	1265	1415
			domInteractive	97	35	268	32	105	143
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	209	24	21	50
			firstReactRender	24	20	61	5	24	30
			getState	8	4	102	10	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1187	1008	1785	116	1247	1397
			setupStore	6	4	27	3	6	11
	Webpack	Home	uiStartup	1569	1351	2051	162	1660	1978
			load	1365	1171	1825	150	1457	1731
			domContentLoaded	1364	1171	1824	150	1456	1730
			domInteractive	79	51	357	32	83	124
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	58	7	22	41
			firstReactRender	41	28	53	4	43	49
			getState	10	5	203	20	9	11
			initialActions	0	0	1	0	1	1
			loadScripts	1345	1157	1805	150	1437	1714
			setupStore	11	5	252	25	8	14

Benchmark value 1371 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 2471 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1978 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1731 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1730 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1714 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 3ms | Sum of p95 exceeds: 291ms
Sum of all benchmark exceeds: 294ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -22.65 KiB (-0.42%)
ui: 3.47 KiB (0.05%)
common: -8.01 KiB (-0.1%)

davidmurdoch added 2 commits June 3, 2025 15:07

try to debug flaky vault test

436a4a5

log things

99aca51

metamaskbot added the team-extension-platform Extension Platform team label Jun 3, 2025

davidmurdoch added 2 commits June 3, 2025 16:20

a fix, probably

f3c8e4f

unonly

7fd5e07

maybe?

6eb3793

davidmurdoch commented Jun 4, 2025

View reviewed changes

test/e2e/tests/vault-corruption/vault-corruption.spec.ts Outdated Show resolved Hide resolved

Update test/e2e/tests/vault-corruption/vault-corruption.spec.ts

65df251

Merge branch 'main' into flaky-vault

f781072

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Flaky vault #33460

Flaky vault #33460

davidmurdoch commented Jun 3, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

Uh oh!

Flaky vault #33460

Are you sure you want to change the base?

Flaky vault #33460

Conversation

davidmurdoch commented Jun 3, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 3, 2025

Uh oh!

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

Uh oh!

davidmurdoch commented Jun 3, 2025 •

edited by github-actions bot

Loading