-
Notifications
You must be signed in to change notification settings - Fork 5.2k
chore: use the new @metamask/foundryup
package
#33463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidmurdoch
wants to merge
6
commits into
main
Choose a base branch
from
mm-foundryup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+42
−1,392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (1 files, +22 -124)
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
Builds ready [899c045]
UI Startup Metrics (1209 ± 56 ms)
Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2544 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 305 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1664 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1664 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Sum of mean exceeds: 7ms | Sum of p95 exceeds: 347ms Sum of all benchmark exceeds: 354ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [7449d7d]
UI Startup Metrics (1219 ± 79 ms)
Benchmark value 2566 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 4ms | Sum of p95 exceeds: 355ms Sum of all benchmark exceeds: 359ms Bundle size diffs [🚀 Bundle size reduced!]
|
@metamaskbot update-policies |
No policy changes |
Builds ready [4b6ebff]
UI Startup Metrics (1231 ± 79 ms)
Benchmark value 1196 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 942 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 16ms | Sum of p95 exceeds: 286ms Sum of all benchmark exceeds: 302ms Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [25dd97d]
UI Startup Metrics (1217 ± 62 ms)
Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 54 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2549 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 66ms | Sum of p95 exceeds: 354ms Sum of all benchmark exceeds: 420ms Bundle size diffs [🚀 Bundle size reduced!]
|
@metamask/foundryup
package
Builds ready [2bdb3b5]
UI Startup Metrics (1206 ± 60 ms)
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 14ms | Sum of p95 exceeds: 6ms Sum of all benchmark exceeds: 20ms Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description