Skip to content

chore: use the new @metamask/foundryup package #33463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Jun 3, 2025

Description

Open in GitHub Codespaces

Copy link
Contributor

github-actions bot commented Jun 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Jun 3, 2025
Copy link

socket-security bot commented Jun 3, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​foundryup@​1.0.0741008289100

View full report

@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 3, 2025

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/extension-platform (1 files, +22 -124)
  • 📄 .yarnrc.yml +22 -124

@metamaskbot
Copy link
Collaborator

❌ test-e2e-chrome-api-specs failed. View the html report here.

@metamaskbot
Copy link
Collaborator

Builds ready [899c045]
UI Startup Metrics (1209 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1209109414175612421308
load105095612004910841135
domContentLoaded104494811915010771128
domInteractive171398101630
firstPaint73370114741210671116
backgroundConnect84284820
firstReactRender20164032025
getState1563772126
initialActions001001
loadScripts79670295048823877
setupStore75142811
WebpackHomeuiStartup20691581266423321712543
load16171246220318417281942
domContentLoaded16111242219818417231932
domInteractive161179121347
firstPaint1577038760187288
backgroundConnect249334332342
firstReactRender12243365103108342
getState184317501129
initialActions218134
loadScripts16081240218818217211921
setupStore3363217515305
FirefoxBrowserifyHomeuiStartup13651169172312614491591
load12041014148211112921408
domContentLoaded12041013148211212921408
domInteractive983518929108167
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113103112238
firstReactRender24205852433
getState12418025831
initialActions001001
loadScripts11861001144511012711388
setupStore10420627614
WebpackHomeuiStartup15611358214215916351920
load13621187193314714301664
domContentLoaded13621187193214714301664
domInteractive7655225218197
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414270262243
firstReactRender40275144347
getState10517418915
initialActions102111
loadScripts13411169191414114141588
setupStore85303811
Benchmark value 20 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2544 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 305 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1664 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1664 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Sum of mean exceeds: 7ms | Sum of p95 exceeds: 347ms
Sum of all benchmark exceeds: 354ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 8 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [7449d7d]
UI Startup Metrics (1219 ± 79 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1219106715677912731315
load106092712497011201158
domContentLoaded105392412296911111149
domInteractive171399121530
firstPaint773127117641210921156
backgroundConnect84366822
firstReactRender20153842029
getState1463571828
initialActions001001
loadScripts80768597668869903
setupStore75142810
WebpackHomeuiStartup20901605270324922522566
load16311270205619217571970
domContentLoaded16241267204119017531954
domInteractive151169101342
firstPaint1596341262188286
backgroundConnect22105392642
firstReactRender14542366108275338
getState124152151223
initialActions317135
loadScripts16211265203018917521948
setupStore3273176918304
FirefoxBrowserifyHomeuiStartup1332118216729713611571
load1183105714738712161356
domContentLoaded1183105614738712151356
domInteractive993522631110155
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211391102139
firstReactRender23203222327
getState11518925810
initialActions001001
loadScripts1164104014488511981342
setupStore63374610
WebpackHomeuiStartup15721378192013616741823
load13641178167312314541621
domContentLoaded13631178167312314541620
domInteractive78311652182140
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22168892236
firstReactRender41305744447
getState11519019923
initialActions002111
loadScripts13441159164912314331603
setupStore95788820
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2566 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 355ms
Sum of all benchmark exceeds: 359ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -105.64 KiB (-1.98%)
  • ui: 16.05 KiB (0.22%)
  • common: -5.62 KiB (-0.07%)

@davidmurdoch
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [4b6ebff]
UI Startup Metrics (1231 ± 79 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1231110114737912861394
load106995412687111141195
domContentLoaded106193712527211061185
domInteractive16133141630
firstPaint74378126642110881174
backgroundConnect94305923
firstReactRender21165052134
getState1455682026
initialActions001001
loadScripts81769799970865942
setupStore85283813
WebpackHomeuiStartup20411584250122121812433
load15931254192817317171830
domContentLoaded15871251191017117131821
domInteractive15116591339
firstPaint1626857763175270
backgroundConnect211289102439
firstReactRender14142368111293349
getState1054141117
initialActions215134
loadScripts15841249189917017111811
setupStore4263118516304
FirefoxBrowserifyHomeuiStartup13291166208412113581585
load1173103115458812151337
domContentLoaded1173103115458812151337
domInteractive973427933109147
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313199212148
firstReactRender23205842328
getState10420823810
initialActions001001
loadScripts1153101813868211971319
setupStore9417119611
WebpackHomeuiStartup15871375197113016811809
load13731193169112914821604
domContentLoaded13721193169112914821604
domInteractive78321552186132
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22165762332
firstReactRender43355234649
getState13524925932
initialActions102111
loadScripts13531177167113014631587
setupStore95717819
Benchmark value 1394 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1196 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 942 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 286ms
Sum of all benchmark exceeds: 302ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -105.81 KiB (-1.99%)
  • ui: 16.28 KiB (0.23%)
  • common: -94.57 KiB (-1.13%)

@davidmurdoch davidmurdoch marked this pull request as ready for review June 6, 2025 00:45
@davidmurdoch davidmurdoch requested a review from a team as a code owner June 6, 2025 00:45
@metamaskbot
Copy link
Collaborator

Builds ready [25dd97d]
UI Startup Metrics (1217 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1217110213856212431348
load105595612336010831170
domContentLoaded104794712246110741164
domInteractive17134851629
firstPaint841156123136310611164
backgroundConnect95296826
firstReactRender20164552033
getState1463062023
initialActions001001
loadScripts80270097959825914
setupStore85182812
WebpackHomeuiStartup21561628273022522912549
load16581293198317617941942
domContentLoaded16511289197417517861924
domInteractive15114881342
firstPaint1706465182229301
backgroundConnect2414171172742
firstReactRender15345388119311361
getState175319431224
initialActions317134
loadScripts16481287196317417831913
setupStore5473509920315
FirefoxBrowserifyHomeuiStartup13571175200411514031533
load1200104815269112511351
domContentLoaded1200104815269112511350
domInteractive993422328109164
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221397132153
firstReactRender24215552428
getState10418619810
initialActions001001
loadScripts1181103414879012291336
setupStore64353611
WebpackHomeuiStartup15201354214413015741768
load13151170193311813551544
domContentLoaded13151169193311813551544
domInteractive79465314880112
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2215274262128
firstReactRender41304844347
getState11422222930
initialActions102111
loadScripts12951150191811513371520
setupStore9510211824
Benchmark value 841 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 54 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2549 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 315 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 66ms | Sum of p95 exceeds: 354ms
Sum of all benchmark exceeds: 420ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: -23 Bytes (0%)

@davidmurdoch davidmurdoch changed the title chore: use the new @metamask/foundryup package chore: use the new @metamask/foundryup package Jun 7, 2025
@davidmurdoch davidmurdoch requested review from cortisiko and seaona June 7, 2025 01:24
@metamaskbot
Copy link
Collaborator

Builds ready [2bdb3b5]
UI Startup Metrics (1206 ± 60 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1206107313646012541292
load104791611765710871133
domContentLoaded104091211725810801124
domInteractive16133141628
firstPaint80788114638210721130
backgroundConnect84275823
firstReactRender20164752132
getState1353171826
initialActions001001
loadScripts79967590557840883
setupStore84183814
WebpackHomeuiStartup20461590260224122292448
load16011262196819117601874
domContentLoaded15941258195319017551871
domInteractive15116181339
firstPaint1686244966199280
backgroundConnect21108492234
firstReactRender13843356112300346
getState134308301121
initialActions512942934
loadScripts15911257194118817531864
setupStore246311581523
FirefoxBrowserifyHomeuiStartup13281154186610813741529
load1171100614519312201330
domContentLoaded1171100614519312201329
domInteractive963532837106162
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2613196232365
firstReactRender23195352328
getState11517223814
initialActions001001
loadScripts114899113768812051300
setupStore74496711
WebpackHomeuiStartup15311324211812116091788
load13261160162110213861546
domContentLoaded13261159162110213861545
domInteractive75311351581102
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415332312233
firstReactRender41325144446
getState95316929
initialActions002111
loadScripts13071144160310313671527
setupStore10515616820
Benchmark value 807 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 14ms | Sum of p95 exceeds: 6ms
Sum of all benchmark exceeds: 20ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: -23 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants