feat: pass trackEvent to DeFiPositionsController

[bergarces]

Description

DeFiPositionsController can now report metrics about DeFi positions when those are being fetched.

It is necessary to pass the trackEvent to the controller in order to report them.

Related issues

Fixes:

Manual testing steps

1. Open the extension with an address that has at least one DeFi position
2. There should be an event with an anonimized summary of those positions

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [bffa20b]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1224 ± 80 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1106	1514	80	1266	1381
			load	1063	955	1317	71	1104	1204
			domContentLoaded	1056	946	1293	70	1096	1198
			domInteractive	17	13	51	5	16	30
			firstPaint	795	137	1305	410	1088	1206
			backgroundConnect	8	4	24	4	8	21
			firstReactRender	19	16	27	2	20	24
			getState	15	5	41	7	19	29
			initialActions	0	0	1	0	0	0
			loadScripts	808	705	1027	68	850	953
			setupStore	8	4	14	2	8	11
	Webpack	Home	uiStartup	2196	1709	2681	213	2334	2538
			load	1716	1282	2112	180	1819	2003
			domContentLoaded	1709	1274	2108	178	1813	1993
			domInteractive	15	11	68	10	13	39
			firstPaint	162	67	350	59	187	289
			backgroundConnect	29	10	401	46	26	48
			firstReactRender	156	44	370	111	300	346
			getState	12	4	35	6	15	22
			initialActions	3	1	8	1	4	5
			loadScripts	1706	1272	2106	177	1811	1991
			setupStore	23	7	312	42	20	32
Firefox	Browserify	Home	uiStartup	1322	1150	1740	116	1366	1617
			load	1179	1034	1572	112	1230	1456
			domContentLoaded	1179	1034	1571	112	1230	1456
			domInteractive	96	38	256	31	108	143
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	62	8	20	39
			firstReactRender	22	20	31	2	23	26
			getState	7	4	37	5	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1162	1022	1556	113	1215	1442
			setupStore	6	4	22	3	6	12
	Webpack	Home	uiStartup	1561	1353	2128	155	1623	1937
			load	1353	1170	1888	137	1433	1597
			domContentLoaded	1353	1169	1887	137	1433	1596
			domInteractive	77	39	254	23	81	115
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	14	260	26	24	46
			firstReactRender	41	28	53	4	44	49
			getState	10	5	97	10	9	29
			initialActions	1	0	2	1	1	2
			loadScripts	1332	1155	1867	132	1414	1569
			setupStore	11	5	266	26	8	19

Benchmark value 1382 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1204 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1198 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1206 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2197 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1717 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1710 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1707 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2539 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1992 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1937 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Sum of mean exceeds: 28ms | Sum of p95 exceeds: 201ms
Sum of all benchmark exceeds: 229ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 26 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)

[metamaskbot]

Builds ready [59328c1]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1230 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1230	1083	1456	71	1272	1343
			load	1066	939	1255	68	1116	1166
			domContentLoaded	1060	931	1246	67	1107	1159
			domInteractive	16	13	31	4	16	28
			firstPaint	787	128	1253	415	1103	1162
			backgroundConnect	8	4	37	5	9	14
			firstReactRender	19	15	46	4	20	24
			getState	14	6	39	7	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	813	692	997	65	860	913
			setupStore	7	4	17	2	8	10
	Webpack	Home	uiStartup	2037	1588	2641	262	2234	2504
			load	1576	1213	2043	209	1727	1939
			domContentLoaded	1569	1207	2020	207	1724	1925
			domInteractive	16	11	56	11	13	48
			firstPaint	161	69	386	52	183	256
			backgroundConnect	29	13	405	51	26	52
			firstReactRender	131	43	360	105	130	348
			getState	17	4	346	45	13	23
			initialActions	3	1	7	1	3	4
			loadScripts	1566	1204	2010	206	1722	1914
			setupStore	39	7	317	81	17	299
Firefox	Browserify	Home	uiStartup	1382	1175	1852	116	1453	1594
			load	1224	1022	1715	110	1280	1427
			domContentLoaded	1224	1022	1715	110	1279	1427
			domInteractive	100	35	319	34	111	146
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	159	16	23	45
			firstReactRender	24	21	36	3	24	30
			getState	9	3	193	19	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1204	1007	1702	111	1264	1413
			setupStore	8	4	73	8	7	12
	Webpack	Home	uiStartup	1634	1401	2425	200	1708	2161
			load	1415	1196	2047	174	1497	1822
			domContentLoaded	1415	1196	2047	174	1496	1822
			domInteractive	77	33	166	17	85	107
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	52	6	23	33
			firstReactRender	43	30	67	5	45	49
			getState	15	5	326	39	9	29
			initialActions	0	0	2	1	1	1
			loadScripts	1396	1178	2032	173	1480	1791
			setupStore	11	5	281	28	8	19

Benchmark value 40 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2505 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 299 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1634 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1416 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1416 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1397 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2161 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1822 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1822 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1791 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 141ms | Sum of p95 exceeds: 996ms
Sum of all benchmark exceeds: 1137ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 26 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)

[metamaskbot]

Builds ready [433e4da]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1242 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1242	1106	1481	75	1278	1406
			load	1072	947	1249	70	1115	1216
			domContentLoaded	1064	943	1241	69	1108	1208
			domInteractive	17	13	98	9	16	30
			firstPaint	780	79	1248	417	1094	1188
			backgroundConnect	9	4	50	7	9	27
			firstReactRender	22	15	53	7	23	37
			getState	16	6	46	9	21	30
			initialActions	0	0	1	0	0	1
			loadScripts	813	701	991	69	854	962
			setupStore	8	4	26	3	9	15
	Webpack	Home	uiStartup	2119	1578	2553	236	2285	2508
			load	1660	1247	1993	181	1785	1933
			domContentLoaded	1654	1243	1989	180	1780	1920
			domInteractive	15	11	55	8	13	42
			firstPaint	167	68	372	61	199	288
			backgroundConnect	25	10	327	31	24	45
			firstReactRender	137	43	416	108	120	354
			getState	12	4	166	17	11	23
			initialActions	3	1	6	1	3	4
			loadScripts	1651	1241	1979	178	1778	1909
			setupStore	22	7	317	50	16	37
Firefox	Browserify	Home	uiStartup	1341	1189	1764	99	1412	1507
			load	1186	1051	1502	84	1235	1347
			domContentLoaded	1186	1050	1502	84	1235	1347
			domInteractive	95	35	186	24	110	133
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	56	6	20	29
			firstReactRender	23	19	43	3	23	29
			getState	11	4	245	24	8	26
			initialActions	0	0	1	0	0	1
			loadScripts	1169	1034	1489	83	1215	1329
			setupStore	8	4	179	18	7	12
	Webpack	Home	uiStartup	1627	1380	2190	163	1720	1957
			load	1411	1199	1923	153	1496	1736
			domContentLoaded	1410	1199	1923	153	1495	1736
			domInteractive	79	36	159	19	82	121
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	57	6	23	31
			firstReactRender	43	28	63	5	46	52
			getState	10	5	44	7	9	30
			initialActions	1	0	2	1	1	1
			loadScripts	1391	1181	1907	154	1478	1719
			setupStore	12	5	215	23	8	26

Benchmark value 1243 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1072 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 1406 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1216 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1209 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1188 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 28 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 963 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2509 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1627 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1411 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1411 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1392 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1957 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1736 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1736 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 1719 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 127ms | Sum of p95 exceeds: 459ms
Sum of all benchmark exceeds: 586ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 26 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)