feat: Add --features option to legacy build system CLI

[rekmarks]

Description

Teams have been testing features in different build types by modifying builds.yml without committing the changes. To improve upon this sorry situation, this PR adds a --features option to the legacy build system CLI. You can specify any feature defined under the top-level features property of builds.yml. Redundantly specified features are permitted.

The "active features" are implemented as a frozen array private to development/build/config.js. This array is set once, by setActiveFeatures() during parseArgv() in development/build/index.js. The array can only be set once. Rather than threading the active features through the various build system functions, we always retrieve mutable copies of the cached active features via getActiveFeatures().

Manual testing steps

Additional features

Any feature not in the active build type will do, but for example:

1. yarn start --features bitcoin
2. Wait for the build to finish
3. Open the dev console for the background service worker
4. Observe errors in the background console about various Bitcoin things

Redundant features

1. yarn start --features build-main
2. This should behave identically to yarn start

Non-existent features

1. yarn start --features foo
2. This should error

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [25539ed]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1232 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1232	1083	1377	62	1281	1343
			load	1068	944	1215	64	1117	1181
			domContentLoaded	1062	940	1209	64	1113	1163
			domInteractive	17	13	104	10	16	29
			firstPaint	740	79	1163	421	1088	1141
			backgroundConnect	8	4	30	5	8	23
			firstReactRender	20	15	40	4	21	28
			getState	14	5	64	8	19	25
			initialActions	0	0	1	0	0	1
			loadScripts	813	701	953	62	865	915
			setupStore	8	5	32	4	8	12
	Webpack	Home	uiStartup	2126	1571	2633	232	2271	2555
			load	1658	1235	2005	179	1775	1969
			domContentLoaded	1651	1231	1996	178	1770	1957
			domInteractive	15	11	60	9	13	45
			firstPaint	165	62	385	64	216	292
			backgroundConnect	22	10	65	9	24	44
			firstReactRender	142	44	364	106	219	347
			getState	14	4	332	33	13	29
			initialActions	3	1	5	1	3	4
			loadScripts	1648	1230	1985	176	1768	1946
			setupStore	26	6	314	58	17	44
Firefox	Browserify	Home	uiStartup	1371	1186	1956	130	1423	1599
			load	1215	1057	1503	107	1287	1441
			domContentLoaded	1214	1056	1502	107	1287	1441
			domInteractive	98	36	375	36	109	138
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	302	29	21	45
			firstReactRender	23	20	34	2	24	28
			getState	10	4	181	18	8	20
			initialActions	0	0	36	4	0	1
			loadScripts	1196	1039	1479	104	1265	1418
			setupStore	7	3	87	8	6	12
	Webpack	Home	uiStartup	1647	1391	2306	178	1744	2031
			load	1428	1216	1975	168	1512	1829
			domContentLoaded	1427	1216	1975	168	1512	1828
			domInteractive	77	38	151	20	86	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	94	8	24	31
			firstReactRender	43	31	54	4	46	50
			getState	13	6	197	20	10	32
			initialActions	1	0	2	1	1	1
			loadScripts	1407	1200	1953	166	1492	1805
			setupStore	10	5	84	12	8	17

Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2556 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1647 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1428 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1428 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1407 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2031 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1829 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1828 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1805 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 183ms | Sum of p95 exceeds: 716ms
Sum of all benchmark exceeds: 899ms

Bundle size diffs

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)

[metamaskbot]

Builds ready [fc59f41]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1206 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1206	1087	1390	62	1247	1322
			load	1037	919	1205	59	1071	1146
			domContentLoaded	1029	913	1199	60	1063	1138
			domInteractive	16	13	40	5	15	28
			firstPaint	679	134	1216	412	1046	1135
			backgroundConnect	9	4	44	7	9	25
			firstReactRender	22	15	63	8	22	40
			getState	14	5	37	7	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	781	670	952	59	816	896
			setupStore	8	4	43	4	8	11
	Webpack	Home	uiStartup	2131	1673	2629	241	2306	2541
			load	1663	1287	2162	199	1783	1978
			domContentLoaded	1656	1282	2150	198	1773	1967
			domInteractive	16	11	84	11	13	45
			firstPaint	168	66	414	72	189	324
			backgroundConnect	25	10	326	31	26	41
			firstReactRender	145	44	364	112	301	351
			getState	11	4	39	5	12	21
			initialActions	3	1	5	1	3	4
			loadScripts	1653	1281	2139	197	1770	1961
			setupStore	28	6	326	60	18	264
Firefox	Browserify	Home	uiStartup	1334	1144	1709	103	1396	1538
			load	1188	1021	1559	104	1257	1404
			domContentLoaded	1188	1021	1558	104	1257	1403
			domInteractive	99	37	270	33	112	169
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	83	9	19	30
			firstReactRender	23	20	32	2	23	28
			getState	8	4	68	8	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1170	1005	1539	104	1234	1380
			setupStore	6	4	22	2	6	10
	Webpack	Home	uiStartup	1565	1368	2109	163	1642	1970
			load	1363	1187	1934	153	1443	1727
			domContentLoaded	1362	1186	1934	153	1443	1727
			domInteractive	81	57	213	24	87	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	46	6	22	39
			firstReactRender	41	27	56	5	44	50
			getState	8	4	30	4	8	18
			initialActions	1	0	2	1	1	1
			loadScripts	1345	1171	1918	153	1424	1706
			setupStore	8	5	59	6	8	12

Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2541 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 264 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1970 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1727 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1727 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1706 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 539ms
Sum of all benchmark exceeds: 543ms

Bundle size diffs

• background: 0 Bytes (0%)
• ui: 0 Bytes (0%)
• common: 0 Bytes (0%)