-
Notifications
You must be signed in to change notification settings - Fork 5.2k
(DRAFT) feat: MMS-2553 unified UI for swaps and bridges #33487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ghgoodreau
wants to merge
2
commits into
main
Choose a base branch
from
mms-2553-swaps-unified-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (2 files, +74 -31)
|
Builds ready [27b891d]
UI Startup Metrics (1231 ± 76 ms)
Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2471 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1375 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1986 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1744 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1744 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1723 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 50ms | Sum of p95 exceeds: 374ms Sum of all benchmark exceeds: 424ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist