Skip to content

(DRAFT) feat: MMS-2553 unified UI for swaps and bridges #33487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Jun 5, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Jun 5, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (2 files, +74 -31)
  • 📁 ui/
    • 📁 hooks/
      • 📁 bridge/
        • 📄 useTokensWithFiltering.ts +3 -2
    • 📁 pages/
      • 📁 bridge/
        • 📁 prepare/
          • 📄 prepare-bridge-page.tsx +71 -29

@metamaskbot
Copy link
Collaborator

Builds ready [27b891d]
UI Startup Metrics (1231 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1231110414397612841354
load106693412677211211201
domContentLoaded106093012597211141196
domInteractive16133131626
firstPaint766136122941211001174
backgroundConnect84324820
firstReactRender21164652234
getState1454982030
initialActions001001
loadScripts813694101271865953
setupStore85212812
WebpackHomeuiStartup20871644258323822602471
load16301273203519117601919
domContentLoaded16241269203118917561908
domInteractive161187131344
firstPaint1606335557180298
backgroundConnect23124972737
firstReactRender14343366109288340
getState134323321120
initialActions512832834
loadScripts16211267202218817551897
setupStore206307411742
FirefoxBrowserifyHomeuiStartup13551157169612414221596
load12021017157011312721443
domContentLoaded12011017156911312721443
domInteractive993833140102163
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19135552027
firstReactRender23203222428
getState12418528811
initialActions005101
loadScripts11851003155511312551423
setupStore74729612
WebpackHomeuiStartup16061337219317017011986
load13951155196315415011744
domContentLoaded13941154196215415011744
domInteractive80402432488108
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415259242242
firstReactRender42285454550
getState13424326930
initialActions102111
loadScripts13741137194315214801723
setupStore85667815
Benchmark value 1202 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2471 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1395 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1375 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1986 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1744 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1744 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1723 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 50ms | Sum of p95 exceeds: 374ms
Sum of all benchmark exceeds: 424ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 984 Bytes (0.02%)
  • ui: 1.28 KiB (0.02%)
  • common: -112 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants