Skip to content

feat: Integrate enabled network map (feature flag) #33488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: feat/multi-network-enablement-selectors-2
Choose a base branch
from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Jun 5, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title chore: set REMOVE_GNS to true feat: Integrate enabled network map (feature flag) Jun 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [dced512]
UI Startup Metrics (1209 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1209108613476212521326
load103891511736410791158
domContentLoaded103190511676510751153
domInteractive16133141627
firstPaint72180117340810481125
backgroundConnect84295823
firstReactRender2316152152248
getState1464582128
initialActions001001
loadScripts78665491964826896
setupStore85244919
WebpackHomeuiStartup21141638261623622682511
load16451291215318517611940
domContentLoaded16391286214818417551924
domInteractive161161111349
firstPaint1726369096190354
backgroundConnect21134272537
firstReactRender14744364111293347
getState154318331223
initialActions812974134
loadScripts16361285213818217531915
setupStore246312491833
FirefoxBrowserifyHomeuiStartup13221172184611213741538
load1168103214468912261365
domContentLoaded1167103214468912251364
domInteractive953424431107144
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20136292141
firstReactRender23204932328
getState12419228826
initialActions001001
loadScripts1150102314108812051348
setupStore74395611
WebpackHomeuiStartup16251387213516317072003
load14091188187915414971729
domContentLoaded14081187187915414971729
domInteractive79351812183131
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22156062330
firstReactRender433011684548
getState11524724929
initialActions001011
loadScripts13891169185715314821716
setupStore85304817
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 48 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2511 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 354 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1626 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1409 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1409 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1389 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2003 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1729 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1729 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1716 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 108ms | Sum of p95 exceeds: 382ms
Sum of all benchmark exceeds: 490ms

@metamaskbot
Copy link
Collaborator

Builds ready [a403443]
UI Startup Metrics (1222 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1222110315577012691345
load106095013396511011165
domContentLoaded105494413356510951159
domInteractive171395101631
firstPaint753138134041510721161
backgroundConnect84345823
firstReactRender20164232026
getState1463161925
initialActions001001
loadScripts806702107863841910
setupStore75172811
WebpackHomeuiStartup20941577253721522382457
load16231251196316917411895
domContentLoaded16171247195316817371883
domInteractive15115591341
firstPaint1585939968196283
backgroundConnect21104772537
firstReactRender14444358110252349
getState1044751120
initialActions216134
loadScripts16141246194316717351873
setupStore3473107317301
FirefoxBrowserifyHomeuiStartup13821233178811114321602
load12291074161710912881468
domContentLoaded12291074161710912871468
domInteractive1003717627114154
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21135172240
firstReactRender24213322528
getState84394811
initialActions001001
loadScripts12111045160310912741449
setupStore74626611
WebpackHomeuiStartup15971371225318416722033
load13891175194816814561803
domContentLoaded13891175194716814561802
domInteractive77423022883102
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2515235302238
firstReactRender41285244448
getState10511612929
initialActions001011
loadScripts13671161193216314401787
setupStore10524123811
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2458 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1390 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1390 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1367 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2033 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1803 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1802 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1787 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 33ms | Sum of p95 exceeds: 786ms
Sum of all benchmark exceeds: 819ms

@metamaskbot
Copy link
Collaborator

Builds ready [5e58268]
UI Startup Metrics (1240 ± 71 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1240109714977112811386
load107295312956611171175
domContentLoaded106594712896611111169
domInteractive171310091621
firstPaint742132129842811061148
backgroundConnect84285824
firstReactRender21164562138
getState1464982028
initialActions001001
loadScripts817704102065862926
setupStore95253917
WebpackHomeuiStartup21011623259524522882500
load16351211200019917731912
domContentLoaded16291207197619817661901
domInteractive15114581340
firstPaint1717434760214262
backgroundConnect239151162544
firstReactRender13643364101138351
getState1146171223
initialActions327134
loadScripts16261205196519617641892
setupStore277318591752
FirefoxBrowserifyHomeuiStartup13381172197312813931612
load11861050179211112521377
domContentLoaded11861050179211112521377
domInteractive963353651100140
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413212292049
firstReactRender23213422428
getState10416318810
initialActions001001
loadScripts11641034159510012351355
setupStore83689616
WebpackHomeuiStartup15761384214912716841805
load13651190190512214451598
domContentLoaded13651190190412214451598
domInteractive76341421685113
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2316199182333
firstReactRender42276754449
getState105336929
initialActions001011
loadScripts13441175171611614291577
setupStore12524626821
Benchmark value 1240 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1072 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1065 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1386 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2501 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 17ms | Sum of p95 exceeds: 75ms
Sum of all benchmark exceeds: 92ms

@metamaskbot
Copy link
Collaborator

Builds ready [f62b59b]
UI Startup Metrics (1242 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1242113013755912841353
load106995211985611111162
domContentLoaded106294811935611061154
domInteractive17144141627
firstPaint73985119541910851156
backgroundConnect84375812
firstReactRender20163632128
getState1454392031
initialActions001001
loadScripts81171293453854901
setupStore85303913
WebpackHomeuiStartup20861583255023822512480
load16201231196818917581895
domContentLoaded16141225195318817521885
domInteractive14114771338
firstPaint178621733166193266
backgroundConnect259379372442
firstReactRender13744366110122348
getState144295321125
initialActions215134
loadScripts16111223194418717511874
setupStore3463537418281
FirefoxBrowserifyHomeuiStartup1342118416819713891547
load1191103913998012431354
domContentLoaded1191103813998012431353
domInteractive963627133103146
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113143162040
firstReactRender23203222327
getState10423423818
initialActions001001
loadScripts1172102513848012291329
setupStore74576611
WebpackHomeuiStartup15561350198812816611810
load13511163161411914671565
domContentLoaded13511162161311914671565
domInteractive75321531681110
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2315244232235
firstReactRender41275354548
getState95315921
initialActions102111
loadScripts13301147159511614331543
setupStore9513714813
Benchmark value 1242 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2480 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 281 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 17ms | Sum of p95 exceeds: 242ms
Sum of all benchmark exceeds: 259ms

@metamaskbot
Copy link
Collaborator

Builds ready [7e1cfad]
UI Startup Metrics (1238 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1238110815287312861344
load107393713376811221174
domContentLoaded106693213336811151168
domInteractive16133841627
firstPaint748129134642310901174
backgroundConnect84264820
firstReactRender21174862138
getState1663682130
initialActions001000
loadScripts818690106065868920
setupStore85263815
WebpackHomeuiStartup20761600255224122192477
load16201261196518717481877
domContentLoaded16141257195718617431863
domInteractive15114571339
firstPaint1696131861217270
backgroundConnect23106382739
firstReactRender1254439698112346
getState124157161223
initialActions612882835
loadScripts16111255194618517391852
setupStore3363567318308
FirefoxBrowserifyHomeuiStartup13791193176611114521621
load1221106514638912841381
domContentLoaded1221106514638912831381
domInteractive1003527633116153
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2214202192249
firstReactRender23214022427
getState11420826814
initialActions001001
loadScripts1202105514459012661364
setupStore947411736
WebpackHomeuiStartup15431375185311616251772
load13421189160010814291542
domContentLoaded13421189160010814291542
domInteractive78341441785116
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21144872140
firstReactRender41325434347
getState85172911
initialActions002111
loadScripts13241173158010814081527
setupStore10525225817
Benchmark value 1239 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1074 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2477 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 22ms | Sum of p95 exceeds: 278ms
Sum of all benchmark exceeds: 300ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants