-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: Integrate enabled network map (feature flag) #33488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gambinish
wants to merge
7
commits into
feat/multi-network-enablement-selectors-2
Choose a base branch
from
feat/multi-network-enablement-selectors-3
base: feat/multi-network-enablement-selectors-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Integrate enabled network map (feature flag) #33488
gambinish
wants to merge
7
commits into
feat/multi-network-enablement-selectors-2
from
feat/multi-network-enablement-selectors-3
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [dced512]
UI Startup Metrics (1209 ± 62 ms)
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 48 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2511 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 354 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 1626 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1409 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1409 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1389 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2003 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1729 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1729 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1716 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 108ms | Sum of p95 exceeds: 382ms Sum of all benchmark exceeds: 490ms |
Builds ready [a403443]
UI Startup Metrics (1222 ± 70 ms)
Benchmark value 34 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2458 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1390 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1390 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1367 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2033 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1803 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1802 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1787 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 33ms | Sum of p95 exceeds: 786ms Sum of all benchmark exceeds: 819ms |
…lti-network-enablement-selectors-3
Builds ready [5e58268]
UI Startup Metrics (1240 ± 71 ms)
Benchmark value 1072 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1065 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 1386 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 2501 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 17ms | Sum of p95 exceeds: 75ms Sum of all benchmark exceeds: 92ms |
Builds ready [f62b59b]
UI Startup Metrics (1242 ± 59 ms)
Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2480 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 281 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 17ms | Sum of p95 exceeds: 242ms Sum of all benchmark exceeds: 259ms |
…lti-network-enablement-selectors-3
7 tasks
Prithpal-Sooriya
approved these changes
Jun 5, 2025
…lti-network-enablement-selectors-3
Builds ready [7e1cfad]
UI Startup Metrics (1238 ± 73 ms)
Benchmark value 1074 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2477 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 22ms | Sum of p95 exceeds: 278ms Sum of all benchmark exceeds: 300ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist