chore: update transaction controller #33490

vinistevam · 2025-06-05T07:47:37Z

Description

This PR aims to update the transaction controller to 47.1.0 (minor).

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4991

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-06-05T07:47:48Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-06-05T07:49:02Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/transaction-controller@57.0.0 ⏵ 57.1.0	⁺⁴		⁺¹

View full report

metamaskbot · 2025-06-05T08:10:41Z

Builds ready [7cda1ab]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1215 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1215	1101	1478	67	1252	1337
			load	1052	906	1219	63	1096	1163
			domContentLoaded	1045	900	1214	64	1090	1156
			domInteractive	16	13	40	5	16	29
			firstPaint	787	77	1217	404	1080	1156
			backgroundConnect	8	4	28	4	8	21
			firstReactRender	22	16	130	12	21	34
			getState	15	6	55	8	21	31
			initialActions	0	0	1	0	0	1
			loadScripts	799	651	966	63	844	908
			setupStore	8	5	17	2	8	13
	Webpack	Home	uiStartup	2047	1575	2522	229	2197	2422
			load	1600	1247	2060	184	1729	1904
			domContentLoaded	1595	1243	2054	183	1723	1890
			domInteractive	15	11	50	9	13	40
			firstPaint	164	63	403	64	190	282
			backgroundConnect	24	10	333	32	24	32
			firstReactRender	124	44	361	96	123	332
			getState	13	4	318	31	11	19
			initialActions	5	1	284	28	3	4
			loadScripts	1592	1241	2044	181	1720	1879
			setupStore	28	7	312	63	17	256
Firefox	Browserify	Home	uiStartup	1342	1183	1807	95	1387	1516
			load	1196	1058	1654	100	1253	1384
			domContentLoaded	1196	1058	1653	99	1253	1384
			domInteractive	97	36	199	29	111	165
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	83	11	20	47
			firstReactRender	23	20	52	3	23	28
			getState	7	4	10	1	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1177	1029	1636	101	1235	1367
			setupStore	6	4	33	4	6	11
	Webpack	Home	uiStartup	1566	1337	2058	149	1643	1831
			load	1362	1163	1848	142	1445	1618
			domContentLoaded	1361	1163	1848	142	1445	1618
			domInteractive	76	36	210	22	77	115
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	57	7	22	42
			firstReactRender	41	27	56	5	44	47
			getState	9	5	31	6	9	27
			initialActions	0	0	2	1	1	1
			loadScripts	1342	1147	1831	142	1428	1602
			setupStore	8	5	71	7	8	13

Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 256 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 3ms | Sum of p95 exceeds: 194ms
Sum of all benchmark exceeds: 197ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -5 Bytes (0%)
ui: -8 Bytes (0%)
common: 3 KiB (0.04%)

metamaskbot · 2025-06-05T14:19:50Z

Builds ready [64daf32]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1251 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1251	1121	1492	69	1296	1371
			load	1083	973	1321	68	1122	1206
			domContentLoaded	1076	959	1317	68	1114	1194
			domInteractive	17	14	51	5	17	29
			firstPaint	711	144	1325	438	1093	1189
			backgroundConnect	8	4	30	5	9	23
			firstReactRender	21	16	42	5	21	31
			getState	14	6	36	9	20	32
			initialActions	0	0	1	0	0	1
			loadScripts	826	711	1059	68	865	945
			setupStore	8	5	37	4	9	13
	Webpack	Home	uiStartup	2159	1609	2567	210	2301	2474
			load	1674	1283	1978	161	1800	1894
			domContentLoaded	1668	1279	1964	160	1794	1882
			domInteractive	15	11	47	8	13	39
			firstPaint	158	64	276	50	191	252
			backgroundConnect	22	10	74	9	25	43
			firstReactRender	159	43	371	114	307	353
			getState	12	4	45	7	13	23
			initialActions	3	1	6	1	3	5
			loadScripts	1665	1277	1951	158	1792	1870
			setupStore	30	7	341	65	18	296
Firefox	Browserify	Home	uiStartup	1369	1181	1793	109	1423	1598
			load	1210	1051	1557	98	1268	1419
			domContentLoaded	1209	1051	1557	98	1267	1419
			domInteractive	104	35	535	55	117	160
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	60	9	22	48
			firstReactRender	24	21	52	3	24	28
			getState	12	4	194	26	8	27
			initialActions	0	0	1	0	0	1
			loadScripts	1190	1037	1531	98	1252	1391
			setupStore	8	4	79	8	7	16
	Webpack	Home	uiStartup	1543	1403	1951	112	1597	1772
			load	1332	1202	1691	101	1374	1539
			domContentLoaded	1332	1202	1690	101	1373	1538
			domInteractive	77	32	343	32	81	110
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	227	22	23	41
			firstReactRender	42	29	91	7	44	48
			getState	13	5	200	20	10	31
			initialActions	0	0	1	0	1	1
			loadScripts	1311	1185	1674	100	1351	1516
			setupStore	9	5	73	9	8	24

Benchmark value 1252 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1084 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1077 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1372 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1206 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1194 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1190 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 945 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2474 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 296 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 53ms | Sum of p95 exceeds: 312ms
Sum of all benchmark exceeds: 365ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 3.04 KiB (0.04%)

metamaskbot · 2025-06-06T04:49:59Z

Builds ready [bac98f4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1093	1410	68	1269	1327
			load	1064	932	1240	68	1105	1163
			domContentLoaded	1056	928	1229	69	1099	1159
			domInteractive	17	13	98	9	15	29
			firstPaint	709	73	1237	433	1092	1160
			backgroundConnect	9	4	62	8	8	24
			firstReactRender	19	15	56	5	20	25
			getState	13	6	32	7	19	25
			initialActions	0	0	1	0	0	1
			loadScripts	813	695	981	69	857	913
			setupStore	7	5	12	2	8	11
	Webpack	Home	uiStartup	2114	1622	2568	230	2286	2475
			load	1634	1281	1971	183	1765	1924
			domContentLoaded	1627	1277	1963	182	1761	1914
			domInteractive	15	11	44	7	13	40
			firstPaint	169	71	426	71	195	304
			backgroundConnect	25	11	241	24	26	40
			firstReactRender	122	43	358	100	100	348
			getState	17	5	309	43	12	29
			initialActions	3	1	6	1	3	4
			loadScripts	1624	1275	1952	181	1759	1903
			setupStore	50	6	321	93	19	307
Firefox	Browserify	Home	uiStartup	1358	1217	1735	89	1415	1528
			load	1203	1060	1444	88	1263	1368
			domContentLoaded	1202	1060	1444	88	1263	1368
			domInteractive	99	35	277	30	112	145
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	82	9	21	43
			firstReactRender	24	21	57	5	24	28
			getState	9	4	176	17	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1184	1046	1419	88	1240	1352
			setupStore	9	4	284	28	6	11
	Webpack	Home	uiStartup	1479	1323	1959	115	1528	1693
			load	1282	1139	1691	109	1314	1504
			domContentLoaded	1282	1138	1690	109	1314	1503
			domInteractive	75	34	168	19	77	123
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	43	5	21	32
			firstReactRender	40	34	56	3	42	45
			getState	8	5	65	6	9	13
			initialActions	1	0	2	1	1	1
			loadScripts	1264	1124	1668	109	1298	1486
			setupStore	8	5	65	7	8	20

Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 51 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2475 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 307 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 22ms | Sum of p95 exceeds: 270ms
Sum of all benchmark exceeds: 292ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -3 Bytes (0%)
ui: -1 Bytes (0%)
common: 3.04 KiB (0.04%)

chore: update transaction controller

7cda1ab

vinistevam added the team-confirmations Push issues to confirmations team label Jun 5, 2025

vinistevam marked this pull request as ready for review June 5, 2025 07:50

Merge branch 'main' into chore/update-transaction-controller-47-1-0

64daf32

Merge branch 'main' into chore/update-transaction-controller-47-1-0

bac98f4

vinistevam added the DO-NOT-MERGE Pull requests that should not be merged label Jun 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: update transaction controller #33490

chore: update transaction controller #33490

Uh oh!

vinistevam commented Jun 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 5, 2025

Uh oh!

socket-security bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 6, 2025

Uh oh!

Uh oh!

chore: update transaction controller #33490

Are you sure you want to change the base?

chore: update transaction controller #33490

Uh oh!

Conversation

vinistevam commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 5, 2025

Uh oh!

socket-security bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

metamaskbot commented Jun 6, 2025

Uh oh!

Uh oh!

vinistevam commented Jun 5, 2025 •

edited

Loading

socket-security bot commented Jun 5, 2025 •

edited

Loading