feat: add AccountTreeController
#33499
Open
+239
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ccharly
force-pushed
the
feat/account-tree-controller
branch
from
317e3a1 to
2a7f0ee
Compare
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (3 files, +39 -9)
📜 @MetaMask/policy-reviewers (3 files, +39 -9)
🔗 @MetaMask/supply-chain (3 files, +39 -9)
|
Builds ready [2a7f0ee]
UI Startup Metrics (1259 ± 67 ms)
Benchmark value 1092 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1085 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 808 exceeds gate value 800 for chrome browserify home mean firstPaint Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1391 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1215 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1210 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1193 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 961 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2495 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 295 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 91ms | Sum of p95 exceeds: 389ms Sum of all benchmark exceeds: 480ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrating the new
AccountTreeController. For now, it's not being used by any other UI components, but other PRs will follow on that.Related issues
N/A
Manual testing steps
jq '.metamask.accountTree' state.json:{ "wallets": { "entropy:01JX08ABR2KRR210DXXYB92H47": { "id": "entropy:01JX08ABR2KRR210DXXYB92H47", "groups": { "entropy:01JX08ABR2KRR210DXXYB92H47:default": { "id": "entropy:01JX08ABR2KRR210DXXYB92H47:default", "accounts": [ "fe7bdb6b-6644-4cf0-a540-800434643e8d", "fa3ca5c5-e0f7-473f-a041-e05e00736183" ], "metadata": { "name": "Default" } } }, "metadata": { "name": "Wallet 1" } }, "entropy:01JX08BFVDY3DPBTKYYYJD3X9Y": { "id": "entropy:01JX08BFVDY3DPBTKYYYJD3X9Y", "groups": { "entropy:01JX08BFVDY3DPBTKYYYJD3X9Y:default": { "id": "entropy:01JX08BFVDY3DPBTKYYYJD3X9Y:default", "accounts": [ "48d6203c-92eb-4ee0-aefa-f3ca78d30d25", "c748a96d-7ba0-4c96-945c-27d308a28348", "d11897a0-8aac-4959-861d-f1e3858fdad2" ], "metadata": { "name": "Default" } } }, "metadata": { "name": "Wallet 2" } }, "entropy:01JX08C7WM3W7YWZM2EEPMBHBG": { "id": "entropy:01JX08C7WM3W7YWZM2EEPMBHBG", "groups": { "entropy:01JX08C7WM3W7YWZM2EEPMBHBG:default": { "id": "entropy:01JX08C7WM3W7YWZM2EEPMBHBG:default", "accounts": [ "0b3368de-aeae-4633-9434-54634444a96a", "7b7fdcd8-ca48-4470-835c-f7703ea256e8" ], "metadata": { "name": "Default" } } }, "metadata": { "name": "Wallet 3" } }, "keyring:Simple Key Pair": { "id": "keyring:Simple Key Pair", "groups": { "keyring:Simple Key Pair:default": { "id": "keyring:Simple Key Pair:default", "accounts": [ "9f6bd546-5a6a-46f4-908f-23c48c0841df", "a0b0d8fb-c6f4-4797-bcac-3cd7be53c07e" ], "metadata": { "name": "Default" } } }, "metadata": { "name": "Private Keys" } }, "snap:npm:@metamask/snap-simple-keyring-snap": { "id": "snap:npm:@metamask/snap-simple-keyring-snap", "groups": { "snap:npm:@metamask/snap-simple-keyring-snap:default": { "id": "snap:npm:@metamask/snap-simple-keyring-snap:default", "accounts": [ "27fd6c96-9d41-4faa-bf69-73f00591c754", "95176c97-da1b-400c-8aa4-2f4b3bbb1c1b" ], "metadata": { "name": "Default" } } }, "metadata": { "name": "Snap: MetaMask Simple Snap Keyring" } } } }Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist