Skip to content

feat: remove wallet standard extra characters #33502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

baptiste-marchand
Copy link
Contributor

@baptiste-marchand baptiste-marchand commented Jun 5, 2025

Description

⚠️ DO NOT MERGE ⚠️
This PR is for testing purposes only

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-wallet-standard Team responsible of the MetaMask Wallet Standard implementation label Jun 5, 2025
@baptiste-marchand baptiste-marchand force-pushed the feat/wallet-standard-remove-extra-character branch from ad344f2 to 90b7541 Compare June 5, 2025 16:10
@metamaskbot
Copy link
Collaborator

Builds ready [90b7541]
UI Startup Metrics (1212 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1212109814266412431344
load104794512715910691172
domContentLoaded104194012645910651167
domInteractive16133951630
firstPaint732139127141210631168
backgroundConnect84485812
firstReactRender20154242127
getState1363571727
initialActions001001
loadScripts79369699557815921
setupStore74111810
WebpackHomeuiStartup21241663263422822902507
load16601302208218417731933
domContentLoaded16491246200118317691916
domInteractive15115381339
firstPaint1616241968184298
backgroundConnect2810364412747
firstReactRender13444370102112347
getState134297291222
initialActions317135
loadScripts16451243199018217681906
setupStore267325571933
FirefoxBrowserifyHomeuiStartup13621205183511114111641
load1204104715418912551373
domContentLoaded1204104615398912551373
domInteractive983518729113157
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2513220252253
firstReactRender23204732329
getState9517016813
initialActions001001
loadScripts1182103214978312321324
setupStore9413816713
WebpackHomeuiStartup15101322191310915891733
load13121155160710114031495
domContentLoaded13121155160610114031495
domInteractive76321371679117
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2215231222037
firstReactRender40295044245
getState94335927
initialActions002111
loadScripts1292113815559713801462
setupStore8561689
Benchmark value 2508 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 54ms
Sum of all benchmark exceeds: 56ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-wallet-standard Team responsible of the MetaMask Wallet Standard implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants