-
Notifications
You must be signed in to change notification settings - Fork 5.2k
chore: use wallet_createSession
from @metamask/multichain-api-middleware
#33511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…-controller to use its wallet_createSession handler
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
@metamaskbot update-policies |
No policy changes |
Builds ready [cb924c4]
UI Startup Metrics (1237 ± 75 ms)
Benchmark value 1073 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 41 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2470 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 309 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 28ms | Sum of p95 exceeds: 277ms Sum of all benchmark exceeds: 305ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (3 files, +3 -33)
📜 @MetaMask/policy-reviewers (3 files, +3 -33)
🔗 @MetaMask/supply-chain (3 files, +3 -33)
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
❌ test-e2e-chrome-api-specs-multichain failed. View the html report here. |
Builds ready [0f5ae31]
UI Startup Metrics (1207 ± 59 ms)
Benchmark value 236 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1246 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1246 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Sum of mean exceeds: 14ms | Sum of p95 exceeds: 179ms Sum of all benchmark exceeds: 193ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
❌ test-e2e-chrome-api-specs failed. View the html report here. |
❌ test-e2e-chrome-api-specs-multichain failed. View the html report here. |
Builds ready [db929c9]
UI Startup Metrics (1235 ± 73 ms)
Benchmark value 1063 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 2499 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 306 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 8ms | Sum of p95 exceeds: 159ms Sum of all benchmark exceeds: 167ms Bundle size diffs [🚀 Bundle size reduced!]
|
This reverts commit 9ac438b.
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [9dd3c8d]
UI Startup Metrics (1246 ± 76 ms)
Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1071 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 1377 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1204 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1198 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1208 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 947 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 311 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 38ms | Sum of p95 exceeds: 343ms Sum of all benchmark exceeds: 381ms Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Bumps
@metamask/multichain-api-middleware
tov0.4.0
and replace localwallet_createSession
handler with the one from this package. Adds aSessionRequested
event tracking hook and removessendMetrics
andmetamaskState
hooks that are no longer used by multichain middleware.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5101
Manual testing steps
wallet_createSession
3.1
SessionRequested
event should fireScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist