Skip to content

fix: bump @metamask/keyring-controller to ^22.0.2 #33513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Jun 6, 2025

Description

See changelog for details:

## [22.0.2]

### Fixed

- Fixed serialized keyring comparison when establishing whether a vault update is needed ([#5928](https://github.com/MetaMask/core/pull/5928))
  - The vault update was being skipped when a keyring class returns an object shallow copy through `.serialize()`.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Pair new Lattice device
  2. Check the pairing step works as expected, and that a new Lattice account has been added

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito marked this pull request as ready for review June 6, 2025 11:33
@mikesposito mikesposito self-assigned this Jun 6, 2025
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​keyring-controller@​22.0.1 ⏵ 22.0.29610076100 +1100

View full report

@metamaskbot
Copy link
Collaborator

Builds ready [214969a]
UI Startup Metrics (1220 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1220110214426712671337
load105595112876111001156
domContentLoaded104893212736110951150
domInteractive17133551732
firstPaint705130128642410571154
backgroundConnect84376826
firstReactRender20153632027
getState1463882032
initialActions001001
loadScripts804698100660854916
setupStore75152811
WebpackHomeuiStartup20531630254821321932435
load15971272191216517061862
domContentLoaded15911269188616316991853
domInteractive14114361331
firstPaint1576033357195283
backgroundConnect20116792338
firstReactRender119434019994347
getState194321521122
initialActions317134
loadScripts15881268187716216971842
setupStore4963169418308
FirefoxBrowserifyHomeuiStartup13191152175511013571550
load1173103015069912091394
domContentLoaded1172103015069912081394
domInteractive993431841107179
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2312191252047
firstReactRender22203122327
getState9414515710
initialActions002001
loadScripts1152101714539311961324
setupStore63344611
WebpackHomeuiStartup16481422204812417381862
load14311234185512515341639
domContentLoaded14301234185512515331639
domInteractive84323063585153
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22174342433
firstReactRender44366354752
getState95313912
initialActions002111
loadScripts14101210183412615161617
setupStore95888912
Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 50 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1648 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1431 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1431 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1411 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Sum of mean exceeds: 211ms | Sum of p95 exceeds: 254ms
Sum of all benchmark exceeds: 465ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 32 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to add Lattice1 accounts - error displayed
3 participants