Skip to content

fix: allow all bitcoin account types #33516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

darioAnongba
Copy link
Contributor

@darioAnongba darioAnongba commented Jun 6, 2025

Description

Allow all Bitcoin account types

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darioAnongba darioAnongba self-assigned this Jun 6, 2025
@darioAnongba darioAnongba requested a review from a team as a code owner June 6, 2025 15:08
@darioAnongba darioAnongba added the team-new-networks PRs from the New Networks team label Jun 6, 2025
Copy link
Contributor

github-actions bot commented Jun 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux (2 files, +6 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-list-menu/
          • 📄 account-list-menu.tsx +3 -0
        • 📁 account-overview/
          • 📄 account-overview.tsx +3 -0

@darioAnongba darioAnongba added team-new-networks PRs from the New Networks team and removed team-new-networks PRs from the New Networks team team-accounts labels Jun 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [b5f8d4d]
UI Startup Metrics (1203 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1203108114276812451338
load104293312106310821173
domContentLoaded103592512056410731167
domInteractive16134041526
firstPaint74180119339910421145
backgroundConnect84275821
firstReactRender20154252130
getState1363171927
initialActions001001
loadScripts79369195062830923
setupStore84162813
WebpackHomeuiStartup21401582265123622932529
load16471223216518317831950
domContentLoaded16401219216018217751940
domInteractive161199121341
firstPaint1667139861195293
backgroundConnect3012272392670
firstReactRender14444365113297350
getState155322311427
initialActions316135
loadScripts16371218215018017721929
setupStore62633710723314
FirefoxBrowserifyHomeuiStartup13371154195711613861548
load1184103415169812421359
domContentLoaded1183103415169812411359
domInteractive993532239104136
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211395122047
firstReactRender22202922327
getState11418524826
initialActions001001
loadScripts1166101715029812211340
setupStore10429029636
WebpackHomeuiStartup15061328192511615721718
load13041148162810913581513
domContentLoaded13041148162810813581512
domInteractive75311672081128
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2415249242340
firstReactRender40295034245
getState95335929
initialActions002111
loadScripts12831132160810513361486
setupStore11522725818
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 63 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2529 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 314 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 35ms | Sum of p95 exceeds: 339ms
Sum of all benchmark exceeds: 374ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 149 Bytes (0%)
  • common: 10 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-new-networks PRs from the New Networks team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants