chore: adding comments to `OperationSafener` helpers; and other internal improvements to `OperationSafener` #33520

davidmurdoch · 2025-06-06T18:33:52Z

Description

Previous PR was merged before I could fix some nit comments. So this is that,

Related: #33486

github-actions · 2025-06-06T18:34:03Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-06-06T18:56:38Z

Builds ready [e7b6ef4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1218 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1218	1107	1387	59	1260	1333
			load	1053	936	1191	56	1095	1158
			domContentLoaded	1046	932	1186	56	1090	1148
			domInteractive	16	13	41	5	16	29
			firstPaint	782	108	1199	397	1072	1157
			backgroundConnect	9	4	35	6	9	24
			firstReactRender	20	15	44	5	20	27
			getState	15	5	57	9	20	29
			initialActions	0	0	1	0	0	1
			loadScripts	801	697	938	56	841	903
			setupStore	8	5	21	3	8	12
	Webpack	Home	uiStartup	2129	1625	2626	227	2278	2510
			load	1667	1267	2027	185	1795	1950
			domContentLoaded	1661	1263	2018	184	1790	1940
			domInteractive	16	12	59	8	13	40
			firstPaint	168	64	438	61	193	267
			backgroundConnect	21	12	41	6	25	34
			firstReactRender	140	44	354	110	280	340
			getState	14	5	310	30	13	23
			initialActions	3	1	8	1	3	4
			loadScripts	1658	1261	2007	183	1788	1929
			setupStore	45	7	318	89	21	313
Firefox	Browserify	Home	uiStartup	1327	1170	1783	129	1379	1650
			load	1162	1010	1380	93	1216	1342
			domContentLoaded	1162	1010	1380	92	1216	1342
			domInteractive	94	35	177	26	104	160
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	13	109	18	24	59
			firstReactRender	23	20	46	3	23	28
			getState	12	4	206	31	8	11
			initialActions	0	0	5	1	0	1
			loadScripts	1141	984	1357	91	1195	1312
			setupStore	11	4	190	25	6	34
	Webpack	Home	uiStartup	1530	1361	1912	120	1622	1771
			load	1330	1166	1658	111	1408	1555
			domContentLoaded	1330	1166	1658	111	1408	1555
			domInteractive	80	30	447	41	83	118
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	49	7	22	40
			firstReactRender	40	27	49	4	43	46
			getState	8	4	31	5	9	19
			initialActions	0	0	2	1	1	1
			loadScripts	1312	1150	1637	111	1392	1536
			setupStore	10	5	278	27	8	10

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 45 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2511 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 313 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 21ms | Sum of p95 exceeds: 318ms
Sum of all benchmark exceeds: 339ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -10 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-06T22:32:24Z

Builds ready [46cd4b8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1197 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1197	1094	1360	57	1240	1295
			load	1039	935	1181	54	1077	1137
			domContentLoaded	1033	931	1176	55	1070	1130
			domInteractive	16	12	58	6	15	28
			firstPaint	683	77	1186	416	1057	1111
			backgroundConnect	8	4	33	5	8	24
			firstReactRender	19	15	33	3	20	24
			getState	14	5	39	7	19	26
			initialActions	0	0	1	0	0	1
			loadScripts	790	699	930	54	829	889
			setupStore	7	4	15	2	7	13
	Webpack	Home	uiStartup	2148	1710	2610	208	2298	2518
			load	1665	1346	2031	166	1785	1914
			domContentLoaded	1659	1342	2026	165	1777	1903
			domInteractive	15	12	57	9	13	41
			firstPaint	166	63	395	67	203	302
			backgroundConnect	26	9	287	27	28	44
			firstReactRender	148	43	363	114	300	351
			getState	23	4	319	57	15	42
			initialActions	3	1	6	1	3	5
			loadScripts	1655	1341	2025	164	1774	1891
			setupStore	36	7	322	74	19	302
Firefox	Browserify	Home	uiStartup	1314	1149	1712	107	1362	1554
			load	1165	1029	1429	92	1214	1357
			domContentLoaded	1164	1029	1428	92	1214	1357
			domInteractive	91	35	222	25	98	136
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	119	12	20	37
			firstReactRender	23	20	57	4	23	29
			getState	10	4	183	20	8	20
			initialActions	0	0	1	0	0	1
			loadScripts	1146	1017	1414	90	1193	1334
			setupStore	8	4	168	17	6	12
	Webpack	Home	uiStartup	1528	1310	1846	112	1594	1767
			load	1326	1154	1589	100	1403	1520
			domContentLoaded	1325	1154	1588	100	1403	1519
			domInteractive	76	36	140	17	82	115
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	60	7	23	36
			firstReactRender	40	30	55	4	43	49
			getState	9	5	31	5	9	19
			initialActions	0	0	1	0	1	1
			loadScripts	1307	1139	1567	101	1389	1498
			setupStore	10	5	170	18	8	16

Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 36 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2518 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 302 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 7ms | Sum of p95 exceeds: 308ms
Sum of all benchmark exceeds: 315ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 310 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-07T01:48:03Z

Builds ready [be26b07]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1216 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1216	1091	1406	64	1264	1322
			load	1058	946	1233	63	1106	1155
			domContentLoaded	1051	931	1226	64	1096	1147
			domInteractive	16	13	35	4	16	28
			firstPaint	772	108	1234	408	1096	1152
			backgroundConnect	8	4	33	6	8	23
			firstReactRender	21	15	44	5	21	34
			getState	13	6	32	7	19	25
			initialActions	0	0	1	0	0	1
			loadScripts	809	695	982	63	857	904
			setupStore	8	5	22	3	9	14
	Webpack	Home	uiStartup	2056	1551	2546	234	2211	2473
			load	1604	1209	1953	185	1737	1917
			domContentLoaded	1598	1205	1949	184	1732	1904
			domInteractive	15	11	62	9	13	38
			firstPaint	161	65	461	73	194	315
			backgroundConnect	20	9	48	6	22	32
			firstReactRender	123	43	354	99	111	330
			getState	13	4	312	30	11	20
			initialActions	5	1	258	25	3	4
			loadScripts	1595	1203	1939	183	1730	1894
			setupStore	50	7	315	96	18	310
Firefox	Browserify	Home	uiStartup	1351	1198	1849	105	1396	1588
			load	1194	1059	1692	89	1239	1332
			domContentLoaded	1193	1059	1692	89	1239	1331
			domInteractive	95	35	245	30	105	148
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	13	187	25	23	90
			firstReactRender	23	20	53	4	24	27
			getState	11	4	181	24	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1171	1031	1592	82	1220	1304
			setupStore	9	4	195	20	7	13
	Webpack	Home	uiStartup	1545	1334	2013	142	1631	1794
			load	1336	1155	1690	123	1436	1562
			domContentLoaded	1335	1154	1689	123	1436	1561
			domInteractive	81	31	330	36	83	144
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	55	8	22	43
			firstReactRender	41	28	68	4	43	47
			getState	11	5	249	25	8	30
			initialActions	1	0	2	1	1	1
			loadScripts	1317	1139	1666	123	1418	1546
			setupStore	12	5	241	32	8	19

Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 51 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2473 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 310 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 90 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 25ms | Sum of p95 exceeds: 289ms
Sum of all benchmark exceeds: 314ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 310 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-07T21:04:30Z

Builds ready [ea61b41]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1216 ± 86 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1216	1090	1757	86	1255	1327
			load	1057	926	1623	83	1088	1146
			domContentLoaded	1050	922	1615	84	1082	1141
			domInteractive	17	13	46	6	16	31
			firstPaint	775	90	1620	412	1074	1139
			backgroundConnect	8	4	28	5	8	25
			firstReactRender	20	14	44	5	20	33
			getState	13	5	44	8	17	29
			initialActions	0	0	1	0	0	1
			loadScripts	805	688	1358	81	838	896
			setupStore	8	5	17	3	9	14
	Webpack	Home	uiStartup	2080	1587	2540	233	2255	2475
			load	1611	1248	1965	185	1757	1871
			domContentLoaded	1604	1244	1947	184	1748	1861
			domInteractive	15	11	47	7	13	38
			firstPaint	166	65	593	69	188	277
			backgroundConnect	29	13	434	53	26	39
			firstReactRender	120	44	363	96	100	330
			getState	13	4	298	29	12	17
			initialActions	3	1	6	1	3	5
			loadScripts	1601	1243	1936	182	1746	1855
			setupStore	64	7	320	110	21	314
Firefox	Browserify	Home	uiStartup	1375	1204	1877	98	1423	1557
			load	1212	1077	1484	82	1270	1373
			domContentLoaded	1212	1077	1484	82	1269	1373
			domInteractive	94	36	189	26	109	128
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	14	133	20	22	64
			firstReactRender	25	21	65	5	24	30
			getState	14	5	397	42	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1190	1062	1411	80	1252	1356
			setupStore	7	4	59	7	6	11
	Webpack	Home	uiStartup	1575	1393	2058	135	1670	1806
			load	1363	1198	1778	128	1463	1597
			domContentLoaded	1362	1197	1778	128	1462	1597
			domInteractive	76	41	120	13	84	105
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	15	225	29	23	45
			firstReactRender	42	35	52	4	45	48
			getState	10	5	64	8	9	30
			initialActions	0	0	1	0	1	1
			loadScripts	1339	1172	1759	122	1427	1561
			setupStore	11	5	200	23	8	13

Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 65 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2476 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 314 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 41ms | Sum of p95 exceeds: 278ms
Sum of all benchmark exceeds: 319ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 310 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

clarifications and comments

e7b6ef4

metamaskbot added the team-extension-platform Extension Platform team label Jun 6, 2025

davidmurdoch changed the title ~~chore: clarifications and comments~~ chore: adding comments to OperationSafener helpers; and other internal improvements to OperationSafener Jun 6, 2025

davidmurdoch added 2 commits June 6, 2025 17:58

error stuff

d30e940

lint

46cd4b8

davidmurdoch changed the title ~~chore: adding comments to OperationSafener helpers; and other internal improvements to OperationSafener~~ chore: adding comments to OperationSafener helpers; and other internal improvements to OperationSafener Jun 7, 2025

Merge branch 'main' into better-reloadv2

be26b07

Merge branch 'main' into better-reloadv2

ea61b41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: adding comments to `OperationSafener` helpers; and other internal improvements to `OperationSafener` #33520

chore: adding comments to `OperationSafener` helpers; and other internal improvements to `OperationSafener` #33520

davidmurdoch commented Jun 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

metamaskbot commented Jun 6, 2025

Uh oh!

metamaskbot commented Jun 6, 2025

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

Uh oh!

chore: adding comments to OperationSafener helpers; and other internal improvements to OperationSafener #33520

Are you sure you want to change the base?

chore: adding comments to OperationSafener helpers; and other internal improvements to OperationSafener #33520

Conversation

davidmurdoch commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

metamaskbot commented Jun 6, 2025

Uh oh!

metamaskbot commented Jun 6, 2025

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

metamaskbot commented Jun 7, 2025

Uh oh!

Uh oh!

chore: adding comments to `OperationSafener` helpers; and other internal improvements to `OperationSafener` #33520

chore: adding comments to `OperationSafener` helpers; and other internal improvements to `OperationSafener` #33520

davidmurdoch commented Jun 6, 2025 •

edited

Loading