Skip to content

test: remove some entries from the mock allow list (part 4) #33521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Jun 6, 2025

Description

Removing some entries from the mock allow list, so we rely on less live requests (eventually 0):

when a test fails due to that, we add the missing mock
when no test fails, we simply let that reqs be catch by the fallback

Related Work:

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jun 6, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 6, 2025

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/extension-platform (1 files, +0 -12)
  • 📁 test/
    • 📁 e2e/
      • 📄 mock-e2e-allowlist.js +0 -12

@metamaskbot
Copy link
Collaborator

Builds ready [1222f15]
UI Startup Metrics (1217 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1217110313776612671332
load105594311795910961163
domContentLoaded104893511746010891157
domInteractive17134461631
firstPaint816134118338510731154
backgroundConnect84315824
firstReactRender21164562039
getState1563782030
initialActions001001
loadScripts80369592860845911
setupStore85193814
WebpackHomeuiStartup21061618255121922332473
load16321293195917317601906
domContentLoaded16271289194817217531896
domInteractive15114971437
firstPaint1706540360198291
backgroundConnect22125582539
firstReactRender13944369106145356
getState144338331220
initialActions326135
loadScripts16241288193617017441886
setupStore3473237318300
FirefoxBrowserifyHomeuiStartup1333117416699813921543
load1183103714148512491350
domContentLoaded1183103714138512481350
domInteractive1073533750110265
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21135882147
firstReactRender23204732328
getState10517519814
initialActions002001
loadScripts1163102313988612291332
setupStore74647611
WebpackHomeuiStartup15261339196411915991733
load13181159167410514041503
domContentLoaded13181159167410514031502
domInteractive732897118095
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22156082240
firstReactRender41335644348
getState105668929
initialActions002111
loadScripts13001140165110513881486
setupStore12525232820
Benchmark value 817 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2473 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 265 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 23ms | Sum of p95 exceeds: 330ms
Sum of all benchmark exceeds: 353ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [6208464]
UI Startup Metrics (1225 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1225108413977212781334
load106693412397211201174
domContentLoaded105993012297211141169
domInteractive16135151628
firstPaint782129124841711031165
backgroundConnect84274822
firstReactRender20154052132
getState1463872026
initialActions004001
loadScripts81669298571873922
setupStore85202814
WebpackHomeuiStartup22191704276421223652591
load17431331207317118322007
domContentLoaded17361326206417018241993
domInteractive161280101443
firstPaint1766554974213300
backgroundConnect2610280272744
firstReactRender13946359106190337
getState194364471535
initialActions3111135
loadScripts17331324205216918231989
setupStore3373166820296
FirefoxBrowserifyHomeuiStartup13731186201313714281653
load12111048180511712541454
domContentLoaded12111048180411712541454
domInteractive1053554861110179
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413106162269
firstReactRender23205442428
getState13522933819
initialActions001001
loadScripts11911031174411412341428
setupStore847711612
WebpackHomeuiStartup15731337202213816791820
load13651155182512914591620
domContentLoaded13641155182512914591619
domInteractive80371612088129
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22157972331
firstReactRender43356144651
getState95326929
initialActions001011
loadScripts13451140179712814411594
setupStore75121810
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2219 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1743 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1737 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1734 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2591 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1990 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 296 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Sum of mean exceeds: 137ms | Sum of p95 exceeds: 393ms
Sum of all benchmark exceeds: 530ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants