-
Notifications
You must be signed in to change notification settings - Fork 5.2k
test: remove some entries from the mock allow list (part 4) #33521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seaona
wants to merge
2
commits into
main
Choose a base branch
from
mock-e2e-allowlist-pt4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+0
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (1 files, +0 -12)
|
Builds ready [1222f15]
UI Startup Metrics (1217 ± 66 ms)
Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2473 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 265 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 23ms | Sum of p95 exceeds: 330ms Sum of all benchmark exceeds: 353ms Bundle size diffs
|
Builds ready [6208464]
UI Startup Metrics (1225 ± 72 ms)
Benchmark value 2219 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1743 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1737 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1734 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2591 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 1990 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 296 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Sum of mean exceeds: 137ms | Sum of p95 exceeds: 393ms Sum of all benchmark exceeds: 530ms Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing some entries from the mock allow list, so we rely on less live requests (eventually 0):
Related Work:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist