Server mocha

[davidmurdoch]

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [caf00b9]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1211 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1211	1091	1440	70	1251	1319
			load	1051	927	1230	64	1092	1156
			domContentLoaded	1043	923	1225	65	1086	1150
			domInteractive	16	13	32	4	16	28
			firstPaint	767	71	1162	404	1076	1137
			backgroundConnect	9	4	27	5	9	23
			firstReactRender	21	16	47	6	21	35
			getState	14	6	82	10	18	30
			initialActions	0	0	1	0	0	0
			loadScripts	803	686	993	64	843	906
			setupStore	8	5	23	3	8	14
	Webpack	Home	uiStartup	2108	1595	2565	237	2266	2547
			load	1631	1257	1970	180	1767	1900
			domContentLoaded	1624	1249	1960	178	1762	1891
			domInteractive	15	11	51	8	13	42
			firstPaint	160	75	467	59	173	270
			backgroundConnect	22	13	62	9	25	40
			firstReactRender	150	44	363	116	308	353
			getState	17	4	315	42	13	36
			initialActions	3	1	7	1	3	4
			loadScripts	1621	1248	1949	177	1757	1880
			setupStore	48	7	322	92	19	310
Firefox	Browserify	Home	uiStartup	1322	1165	1635	100	1372	1540
			load	1170	1024	1393	88	1220	1345
			domContentLoaded	1169	1024	1393	88	1220	1344
			domInteractive	92	33	200	26	101	133
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	115	13	23	48
			firstReactRender	23	20	51	4	23	30
			getState	11	4	175	18	8	36
			initialActions	0	0	1	0	0	1
			loadScripts	1150	981	1360	86	1203	1326
			setupStore	9	4	95	13	7	25
	Webpack	Home	uiStartup	1527	1314	1901	118	1603	1761
			load	1324	1150	1592	109	1395	1555
			domContentLoaded	1324	1150	1591	109	1395	1555
			domInteractive	78	32	140	20	86	122
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	53	6	22	31
			firstReactRender	40	35	48	3	43	46
			getState	11	5	117	14	9	29
			initialActions	1	0	2	1	1	1
			loadScripts	1306	1136	1578	110	1378	1540
			setupStore	9	5	198	19	8	13

Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 48 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2547 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 310 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 19ms | Sum of p95 exceeds: 355ms
Sum of all benchmark exceeds: 374ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 896 Bytes (0.02%)
• ui: 2.39 KiB (0.03%)
• common: 890 Bytes (0.01%)