Skip to content

refactor: asset picker and token list generators #33525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: mms-cp-1220-debounce-input
Choose a base branch
from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jun 7, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Jun 7, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 7, 2025

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (7 files, +253 -317)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 bridge/
          • 📄 bridge-positive-cases.spec.ts +17 -0
  • 📁 ui/
    • 📁 hooks/
      • 📁 bridge/
        • 📄 useBridging.ts +0 -15
        • 📄 useTokensWithFiltering.ts +116 -128
    • 📁 pages/
      • 📁 bridge/
        • 📁 prepare/
          • 📄 bridge-input-group.tsx +55 -74
          • 📄 prepare-bridge-page.tsx +63 -77
        • 📁 quotes/
          • 📄 multichain-bridge-quote-card.tsx +0 -21
          • 📄 index.tsx +2 -2

🖥️ @MetaMask/wallet-ux (4 files, +216 -191)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 asset-picker-amount/
          • 📁 asset-picker/
            • 📄 asset-picker.tsx +25 -15
            • 📄 bridge-asset-picker-button.tsx +28 -6
          • 📁 asset-picker-modal/
            • 📄 asset-picker-modal.tsx +51 -170
            • 📄 utils.ts +112 -0

@metamaskbot
Copy link
Collaborator

❌ test-e2e-chrome-api-specs failed. View the html report here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants