-
-
Notifications
You must be signed in to change notification settings - Fork 675
Fixes #1775 interface class extensions added #1776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes #1775 interface class extensions added #1776
Conversation
…alLytek#1775) These tests will fail without the next upcoming commit which adds extensions into the InterfaceType.
…mmit fixed stylistic issues (MichalLytek#1775)
Can you make sure it works when object type extends interface type and when one interface type extends another interface type? |
… extends interface type related to (MichalLytek#1775) Made sure the tests and code works when object type extends interface type and when one interface type extends another interface type.
@MichalLytek just made another commit. Are the new test cases what you expected? 😄👍 |
Fixes #1775 |
By the way I got this request done @MichalLytek in my last commit. Let me know if there is anything I can do more to get this merged. Thank you! |
Hey @MichalLytek, hopefully I'm not being a bother just wondering if this will get merged, or if there is anything I can do to get this merged. It is not a huge blocker for me, because I'm using patch-package to fix the one line change that needs to be made in the code at the moment for my use case, but it may be useful to have it in that actual repo for others that also need that metadata, thanks! 😎👍 |
Let me know if I can do anything to help get this merged I would appreciate any feedback too.