Skip to content

Improved abs-class-cpp #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Improved abs-class-cpp #2506

wants to merge 4 commits into from

Conversation

jacktherock
Copy link

No description provided.

@PRMerger6
Copy link
Contributor

@jacktherock : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@colin-home
Copy link
Contributor

@jacktherock

We appreciate that you've made the effort to contribute a PR. Some are self-explanatory, but this doesn't seem to fit that category. As far as I can tell, you've only changed some styles, and the changes don't fit our style guidelines. What's your intent with this change, or what issue are you trying to address?

@jacktherock
Copy link
Author

I doesn't have any intent. Just wanted to make some changes to made it more compatible by changing some styles. If you think I did any mistake. You can block my merge otherwise it's in your hand. Thank you!

@colin-home
Copy link
Contributor

@jacktherock Thanks. I'll leave this change out for now.

@colin-home colin-home closed this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants