-
Notifications
You must be signed in to change notification settings - Fork 967
fix typo #3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo #3033
Conversation
@fsb4000 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. I'll look into the other issue.
@fsb4000 |
@corob-msft Thank you very much! I added "N/A" to the cppreference table. |
@fsb4000 I see a similar N/A marking for P1236R1; This entry probably also deserves a "Yes". Signed integers have always been two's complement in the Microsoft compilers. It's the native representation on all architectures MSVC has ever supported. There's never been MSVC support for one's complement or sign-magnitude arithmetic. |
Done! Thanks again! |
@corob-msft "Yes" is better for P1236R1, as left shift operations changed from undefined to well-defined is not diagnosed in constant expression (e.g. |
The link was correct. There is no https://wg21.link/p0962r2
By the way cppreference has https://wg21.link/P0593R6 but your table doesn't have the row. I'm not sure if this row is needed in your table, but I would be very grateful if you could say when P0593R6 was implemented for MSVC?