Skip to content

Add mention of C++ AMP deprecation #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2021
Merged

Add mention of C++ AMP deprecation #3221

merged 5 commits into from
Jun 29, 2021

Conversation

barcharcraz
Copy link
Contributor

C++ AMP headers are deprecated in dev17, add note mentioning that and how to suppress the deprecation error.

I believe the "whats-new-cpp-docs" page I updated is the correct one, but it mentions VS 16.8, so I'm not totally sure.

@PRMerger9
Copy link
Contributor

@barcharcraz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger16
Copy link
Contributor

@barcharcraz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger6 PRMerger6 requested a review from TylerMSFT June 26, 2021 00:15
@PRMerger6
Copy link
Contributor

@barcharcraz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@@ -48,6 +48,7 @@ For the latest C++ conformance status, see [C++ conformance improvements in Visu
- [`assert Macro, _assert, _wassert`](../c-runtime-library/reference/assert-macro-assert-wassert.md) - Clarified assert behavior
- [`vsnprintf_s, _vsnprintf_s, _vsnprintf_s_l, _vsnwprintf_s, _vsnwprintf_s_l`](../c-runtime-library/reference/vsnprintf-s-vsnprintf-s-vsnprintf-s-l-vsnwprintf-s-vsnwprintf-s-l.md) - Clarified return values
- [`setlocale, _wsetlocale`](../c-runtime-library/reference/setlocale-wsetlocale.md) - Added C Runtime UTF-8 support info
- [`C++ AMP Overview`](../parallel/amp/cpp-amp-overview.md) - Added note about C++ AMP deprecation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about pulling this one change out. It's sitting in the section for what's new in VS 16.8
I won't create a new section for VS 2022 until VS 2022 goes out (otherwise it looks like VS 2022 is released).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but we need to remember to add the note to the release notes. It's important people know about the change when upgrading.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't the release notes. This should be noted in the release notes, but not here (yet).

@PRMerger6 PRMerger6 requested a review from TylerMSFT June 29, 2021 19:57
@PRMerger6
Copy link
Contributor

@barcharcraz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @barcharcraz.

@TylerMSFT TylerMSFT merged commit 3cc4398 into MicrosoftDocs:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants