Making /Qspectre 'Required Libraries' section more clear #3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-andreaco
added
aq-pr-triaged
Update to distinguish command line and IDE behavior better. Explicitly call for mitigated libraries in command-line builds. Provide some hand-wavy directions on how. Clarify 2015 behavior and instructions.
colin-home
approved these changes
Jul 3, 2021
|
I may need to tweak something when this gets to the publishing system if the build checks find a problem, but it's good enough to check in here. Thanks @ericbrumer for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A C++ customer opened a DevCom ticket (https://developercommunity.visualstudio.com/t/Build-unexpectedly-succeeds-with-Qspect/1437998) indicating some confusion with what happens when the
/Qspectreswitch is thrown. The compiler switch only modifies the compiler, and our MSBuild properties for C++ projects is what links in the additional libraries.This PR attempts to clear that up.