Skip to content

Add documentation regarding the "unspecified" architecture feature #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 10, 2021

Conversation

gcampbell-msft
Copy link
Contributor

This allows for a feature that does not source an environment to the user. This is useful in non-Windows situations where the user does not want any environment sourced.

Add documentation regarding "unspecified" architecture such that it provides an option for someone to ensure that no inherited environment is selected.
@PRMerger9
Copy link
Contributor

@gcampbell-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@@ -264,6 +264,8 @@ The `architecture.strategy` and `toolset.strategy` values tell CMake how to hand

You should use `set` with IDE generators like the Visual Studio Generator. You should use `external` with command-line generators like Ninja. These values allow vendors like Visual Studio to source the required environment before CMake is invoked. For more information about the architecture and toolset fields, see the [list of Configure Presets](https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#configure-preset).

Additionally, if you do not want any environment sourced, you can set architecture.value to "unspecified" and architecture.strategy to "external". However, you can only do this if you have Ninja set as the generator. Not having any environment sourced could be useful in cases where you are using a toolset other than MSVC where you don't need a specific environment in order to build, or you are in a linux/non-Windows environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to been used with Ninja? I thought it would apply to any command-line generator.

Copy link
Contributor Author

@gcampbell-msft gcampbell-msft Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was based on @bobbrow notes regarding this PR in our email chain saying that the Ninja generator was a requirement.

@PRMerger10
Copy link
Contributor

@gcampbell-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger17 PRMerger17 requested a review from colin-home August 9, 2021 22:57
@PRMerger17
Copy link
Contributor

@gcampbell-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcampbell-msft LGTM. I'll merge the PR when you say you're done.

@PRMerger18
Copy link
Contributor

@gcampbell-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger17 PRMerger17 requested a review from colin-home August 10, 2021 17:08
@PRMerger17 PRMerger17 requested a review from colin-home August 10, 2021 18:05
@PRMerger17
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger13
Copy link
Contributor

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver ktoliver merged commit 2f7e122 into MicrosoftDocs:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.