Create ellipses-and-variadic-templates.md #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess it's often making a difficult choice between making the code sample as simple as possible to convey the informative or taking the risk of using C++ features that make the example more obscure than it needs to be. :-) However, there's also the risk of transmitting information that's copy/pasted again and again when there is a better way to write it in "modern" C++ that all descent compilers support in 2017. That's why I believe: 1. constexpr should be used here instead of const. 2. The size in bytes of the type (size_t) will be different on x86 and x64 so auto (or size_t) would be recommended. 3. Using uniform initialization as it doesn't allow you to implicitly narrow a type into another type: useful here if you'd have compiled under x64 and assigned to an unsigned (32-bit) type.
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
mikeblome
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it's often making a difficult choice between making the code sample as simple as possible to convey the informative or taking the risk of using C++ features that make the example more obscure than it needs to be. :-)
However, there's also the risk of transmitting information that's copy/pasted again and again when there is a better way to write it in "modern" C++ that all descent compilers support in 2017. That's why I believe: