-
Notifications
You must be signed in to change notification settings - Fork 967
Remove the deprecation of IT instructions in the ARM ABI #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecation of IT instructions in the ARM ABI #3509
Conversation
Upstream ARM has undeprecated the use of IT instructions. There's no formal announcement of the matter in itself, but the previous deprecations are being removed from the official docs. See https://reviews.llvm.org/D108679#2975603 for a discussion on the matter.
@mstorsjo : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
#label:"aq-pr-triaged" |
@mstorsjo and cc: @dpaoliello |
@corob-msft The un-deprecation is a change by ARM - there have been no changes that I know of to any Microsoft tools or OSes. From the Windows side, these instructions were always supported, and I don't believe that we ever supported any hardware that didn't support the instructions. |
When it comes to actual processors, there hasn't been any issue so far (as it would break backwards binary compatbility), but I've understood it that they (ARM) reserved the right to degrade/break it later (and thus put in the deprecation preemptively) - but now they've decided that they won't do that, so there's no longer any reason to avoid those constructs. Yeah ideally armasm would also stop warning about these constructs - I guess I could file a public bug report about it, but I'm not sure if it's as effective as if someone of you would start it.
Yeah I don't think there has been any (armv8-a) processors that didn't support those instructions (and the deprecation was added as part of armv8 to begin with). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mstorsjo Thanks for the update and the info. Merging shortly. Docs should be updated tomorrow.
Upstream ARM has undeprecated the use of IT instructions. There's no formal announcement of the matter in itself, but the previous deprecations are being removed from the official docs.
See https://reviews.llvm.org/D108679#2975603 for a discussion on the matter, CC @dpaoliello who was involved in that discussion.