Skip to content

Added example program outputs (#3892) #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2022

Conversation

BrandonPacewic
Copy link
Contributor

This pr fixes #3892.

Added program output for example code as well as fixed the compile errors within the equal_range example code.

@ghost
Copy link

ghost commented May 12, 2022

CLA assistant check
All CLA requirements met.

@PRMerger15
Copy link
Contributor

@BrandonPacewic : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented May 12, 2022

@TylerMSFT

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"

@PRMerger5 PRMerger5 added the aq-pr-triaged Tracking label for the PR review team label May 12, 2022
@PRMerger19
Copy link
Contributor

@BrandonPacewic : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger10
Copy link
Contributor

@BrandonPacewic : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger16
Copy link
Contributor

@BrandonPacewic : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@BrandonPacewic
Copy link
Contributor Author

After looking through more of the documentation it has occurred to me that lots of example code sections do not contain the output of said code. Is this on purpose or because of how each individual decided to write each doc section?

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the output examples and improving the docs.

@TylerMSFT
Copy link
Collaborator

@BrandonPacewic, regarding your question about output samples, yes, it can vary by writer. Some of these docs are very old, were authored at different times when cpub standards and emphasis were different, or came from an earlier publishing system and may have suffered at the hands of automated conversion to the new format. Or someone may have decided that including the output wouldn't add any descriptive value because it was self-evident. Regardless of the reasons, thank you for adding value here. Much appreciated.

@BrandonPacewic
Copy link
Contributor Author

Absolutely, looking forward to making more contributions when I can.

@TylerMSFT
Copy link
Collaborator

TylerMSFT commented May 12, 2022

#sign-off
I was testing out your code change.

@colin-home colin-home merged commit a559843 into MicrosoftDocs:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<algorithm> doc file missing example implementation output + problem with equal_range example
10 participants