Skip to content

add note regarding pch.h files #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rtischer8277
Copy link
Contributor

For a lot of us devs who generated MFC projects years ago, (re)generating new MFC projects create a pch.h header instead of a stdafx.h file. pch.h files include windows header files, but operate differently. This topic should be introduced and I can think of no better way than to address head on how to make CString compile.
The Note I wrote needs to be formatted, for example, with green background.
By the way, I did submit feedback to the Developer Community about this, so maybe they will weigh in on the correct approach to all this. See Unable to compile with MFC CString using new pch.h.

For a lot of us devs who generated MFC projects years ago, (re)generating new MFC projects create a pch.h header instead of a stdafx.h file. pch.h files include windows header files, but operate differently. This topic should be introduced and I can think of no better way than to address head on how to make CString compile.
The Note I wrote needs to be formatted, for example, with green background.
@PRMerger6
Copy link
Contributor

@rtischer8277 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jborsecnik
Copy link
Contributor

@TylerMSFT,

Can you review the proposed changes? Note that the "Note" will have to be changed to the Docs-standard formatting for notes.

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. Thanks.

#label:"aq-pr-triaged"
#assign:@MicrosoftDocs/public-repo-pr-review-team

@PRMerger18
Copy link
Contributor

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team

@PRMerger18 PRMerger18 added the aq-pr-triaged Tracking label for the PR review team label Jun 6, 2022
@TylerMSFT
Copy link
Collaborator

#hold-off
Hi @rtischer8277, thank you for adding to the docs. I need to think about this one first and I'm in the middle of another project. I will circle back to this as soon as I have some time to do so.

@rtischer8277
Copy link
Contributor Author

I think the pch.h CString Note and I am reporting here is a compiler bug and doesn't need a doc Note. CString is properly defined when generating an MFC project using the MFC App template, but not when generating a Dynamic-Link Library set to Using MFC.... I have indicated this change in Unable to compile with MFC CString using new pch.h.

@rtischer8277 rtischer8277 reopened this Jun 6, 2022
@rtischer8277 rtischer8277 deleted the patch-2 branch June 6, 2022 22:01
@TylerMSFT
Copy link
Collaborator

Thanks for logging the bug, @rtischer8277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants