Skip to content

Update tn035-using-multiple-resource-files-and-header-files-with-visu… #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

rtischer8277
Copy link
Contributor

…al-cpp.md

Over the years I have read TN035 maybe a dozen times. Each time I have to (try) to parse the text, figure out what it really means, get past the fact that MS and users aren't going to fix it, then and only then can I solve my programming task at hand.
Only this time, I worked on the text itself and made it clear(er) and unambiguous so at least I in the future can read TN035 and only use 6 minutes to understand the .RC file's Resource Includes dialog instead of a day or two.

…al-cpp.md

Over the years I have read TN035 maybe a dozen times. Each time I have to (try) to parse the text, figure out what it really means, get past the fact that MS and users aren't going to fix it, then and only then can I solve my programming task at hand. 
Only this time, I worked on the text itself and made it clear(er) and unambiguous so at least I in the future can read TN035 and only use 6 minutes to understand the .RC file's Resource Includes dialog instead of a day or two.
@jborsecnik
Copy link
Contributor

@TylerMSFT,

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jborsecnik jborsecnik added the aq-pr-triaged Tracking label for the PR review team label Jun 20, 2022
@PRMerger19 PRMerger19 requested a review from TylerMSFT June 20, 2022 22:18
@PRMerger19
Copy link
Contributor

@rtischer8277 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger16
Copy link
Contributor

@rtischer8277 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@TylerMSFT
Copy link
Collaborator

@AnjuDel , if you are good with this, I'm fine with merging it.

@rtischer8277
Copy link
Contributor Author

rtischer8277 commented Jun 25, 2022

I removed the "escaped-'\'" text. Then, after finding too many corner cases while programming, I removed the Note completely. There was no advice configuration that satisfied all the various ways a non-resource.h include file could be used. The non-informative Cannot save file is the Resource Compiler's main admonition, which unfortunately does not properly advise the programmer. I contend that no amount of documentation can do that which is why I have finally decided to just remove the Note. For my own programming, I have resorted to only using the Resource Script editor when editing the main .RC file, then manually editing the target .RC with its results. This is far from optimal but it lets me get my editing of multiple .RCs done without errors.

…with-visual-cpp.md

Co-authored-by: Anju del Moral Gonzalez <[email protected]>
@PRMerger4
Copy link
Contributor

@TylerMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld31
Copy link

opbld31 commented Jun 28, 2022

Docs Build status updates of commit 8af1bbe:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/tn035-using-multiple-resource-files-and-header-files-with-visual-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@@ -47,17 +47,24 @@ This note is structured to answer the above questions as follows:

Visual C++ manages a single .RC resource file and a corresponding .H header file as a tightly coupled pair of files. When you edit and save resources in an .RC file, you indirectly edit and save symbols in the corresponding .H file. Although you can open and edit multiple .RC files at a time (using Visual C++'s MDI user interface) for any given .RC file you indirectly edit exactly one corresponding header file.

### Symbol Header File
### Resource View's Resource Includes dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Resource View's Resource Includes dialog
### Resource View's Resource Includes dialog
You can access the **Resource Includes** by going to the **Resource View** then right clicking the .rc file and selecting **Resource Includes**

@TylerMSFT
Copy link
Collaborator

Hi @rtischer8277, I'd like to get your work incorporated into the docs. There was a comment from Anju. After ou take a look at that, do you have any other things we need to finish off before we get this in? I have multiple projects going on at the moment and apologize if I've dropped the ball on an outstanding issue you need me to follow up on here.

@TylerMSFT
Copy link
Collaborator

@AnjuDel , can you close with @rtischer8277 on the issue you had so we can get this merged?

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtischer8277 , I talked to Anju and we're going to go ahead and incorporate your changes.
Thank you for taking the time to contribute to the docs!

@TylerMSFT
Copy link
Collaborator

#sign-off

@opbld31
Copy link

opbld31 commented Jul 15, 2022

Docs Build status updates of commit 8af1bbe:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/tn035-using-multiple-resource-files-and-header-files-with-visual-cpp.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.