Skip to content

Fix odd indentation in _popen/_wpopen #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

chwarr
Copy link
Contributor

@chwarr chwarr commented Jun 29, 2017

If you'd rather I not also fix the trailing whitespace errors, I can remove that commit. Let me know.

@msftclas
Copy link

@chwarr,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@colin-home
Copy link
Contributor

The trailing whitespace is significant in our markdown schema. If there aren't two trailing space characters after or between paragraphs, they are merged into a single paragraph in the output HTML, which is rarely what you actually want. This may not be reflected in the preview on GitHub. I suggest dropping that commit.

Within triple-tick code blocks, the trailing spaces are not necessary, though they don't make a visual difference. I tend to remove them when I find them because they may be unexpected when copied into Visual Studio or another editor. Our automated conversion tools that built the markdown files often inserted them, as well as the unexpected space at the beginning of some blocks. I tend to fix those as I come across them. I did some regex searches across the entire document set to fix many, but clearly missed some. These changes are welcome.

@chwarr chwarr force-pushed the fix-popen-indent branch from 6037e4a to 4989357 Compare June 29, 2017 23:39
@chwarr
Copy link
Contributor Author

chwarr commented Jun 29, 2017

Removed the whitespace commit. Thanks for the explanation.

Copy link
Contributor

@colin-home colin-home left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks!

@colin-home colin-home merged commit e46a450 into MicrosoftDocs:master Jun 29, 2017
@chwarr chwarr deleted the fix-popen-indent branch June 29, 2017 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants