Skip to content

Rename pac_sign_lr and update reserved ranges. #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2022
Merged

Rename pac_sign_lr and update reserved ranges. #4209

merged 2 commits into from
Oct 12, 2022

Conversation

pmsjt
Copy link
Contributor

@pmsjt pmsjt commented Oct 11, 2022

No description provided.

@prmerger-automator
Copy link
Contributor

@pmsjt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@pmsjt pmsjt marked this pull request as ready for review October 11, 2022 05:26
@opbld31
Copy link

opbld31 commented Oct 11, 2022

Learn Build status updates of commit cac237d:

✅ Validation status: passed

File Status Preview URL Details
docs/build/arm64-exception-handling.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Oct 11, 2022

@corob-msft

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Oct 11, 2022
@opbld31
Copy link

opbld31 commented Oct 12, 2022

Learn Build status updates of commit eb36c0a:

✅ Validation status: passed

File Status Preview URL Details
docs/build/arm64-exception-handling.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@colin-home
Copy link
Contributor

@pmsjt
Thanks for the expansion. While the compact opcode name appears to be arbitrary, and isn't documented anywhere else, is there a reason other than terseness for choosing pac_sign_lr? At least one internal tool appears to dump the compact opcode as "PAC_SIGN_RETURN_ADDRESS". The linker dumps the compact opcodes as their regular opcode equivalents, so it doesn't get exposed that way.

@pmsjt
Copy link
Contributor Author

pmsjt commented Oct 12, 2022 •
edited
Loading

@pmsjt Thanks for the expansion. While the compact opcode name appears to be arbitrary, and isn't documented anywhere else, is there a reason other than terseness for choosing pac_sign_lr? At least one internal tool appears to dump the compact opcode as "PAC_SIGN_RETURN_ADDRESS". The linker dumps the compact opcodes as their regular opcode equivalents, so it doesn't get exposed that way.

Unwind opcode names are usually short. The previous name stood out like a sore thumb. The rename makes it more consistent with the rest of the naming scheme.

mstorsjo pushed a commit to mstorsjo/cpp-docs that referenced this pull request Oct 12, 2022
@tamarakhader
Merge pull request MicrosoftDocs#4209 from corob-msft/docs/corob/cpp-…
14417cd 
…docs-3816

Address cpp-docs 3816
@colin-home colin-home merged commit 0bd04f6 into MicrosoftDocs:main Oct 12, 2022
mstorsjo added a commit to llvm/llvm-project that referenced this pull request Oct 12, 2022
@mstorsjo
[AArch64] [SEH] Rename pac_sign_return_address to pac_sign_lr
918f6f5 
This new opcode was initially documented as "pac_sign_return_address"
in MicrosoftDocs/cpp-docs#4202, but was
soon afterwards renamed into "pac_sign_lr" in
MicrosoftDocs/cpp-docs#4209, as the other
name was unwieldy, and there were no other external references to
that name anywhere.

Rename our external .seh assembler directive - it hasn't been merged
for very long yet, so there's probably no external use to account for.

Rename all other internal references to the opcode similarly.

Differential Revision: https://reviews.llvm.org/D135762
veselypeta pushed a commit to veselypeta/cherillvm that referenced this pull request May 28, 2024
@mstorsjo @veselypeta
[AArch64] [SEH] Rename pac_sign_return_address to pac_sign_lr
d21d3da 
This new opcode was initially documented as "pac_sign_return_address"
in MicrosoftDocs/cpp-docs#4202, but was
soon afterwards renamed into "pac_sign_lr" in
MicrosoftDocs/cpp-docs#4209, as the other
name was unwieldy, and there were no other external references to
that name anywhere.

Rename our external .seh assembler directive - it hasn't been merged
for very long yet, so there's probably no external use to account for.

Rename all other internal references to the opcode similarly.

Differential Revision: https://reviews.llvm.org/D135762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-home colin-home colin-home approved these changes

Assignees

@colin-home colin-home

Labels
aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-tools/tech do-not-merge qualifies-for-auto-merge visual-cpp/prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmsjt @opbld31 @Court72 @colin-home