-
Notifications
You must be signed in to change notification settings - Fork 967
Update documentation for FASTLINK #4322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The documentation for FASTLINK had a few issues that this PR attempts to address: * The sentence about "executable is deployed on another computer" was confusing because deploying the executable isn't a problem if you are doing so to remote debug. The real problem is attempting to deploy the PDB. * The performance notes on FASTLINK were not correct for Visual Studio 2019 and later
@gregg-miskelly : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
@corob-msft, Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #label:"aq-pr-triaged" |
Learn Build status updates of commit 2d370a7: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Make the grammar checker happy. Use consistent formatting of compiler options.
@gregg-miskelly : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 8c7fce3: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@gregg-miskelly @RussKeldorph "You can only use this limited PDB to debug from the computer where the binary and its libraries were built. If you deploy the binary elsewhere, you may debug it remotely from the build computer, but not directly on the test computer." |
Your sentence sounds fine to me. I will update the PR. |
@gregg-miskelly : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 916ede5: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregg-miskelly @RussKeldorph I'm going to approve and merge this, and if you have any updates, we can make that another PR. Thanks for the contribution.
Thanks @gregg-miskelly and @corob-msft for taking care of this! |
The documentation for FASTLINK had a few issues that this PR attempts to address: