Skip to content

Update tutorial-import-stl-named-module.md #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2023
Merged

Update tutorial-import-stl-named-module.md #4429

merged 2 commits into from
Feb 23, 2023

Conversation

JustaSimpleUser
Copy link
Contributor

The Title of the document doesn't reveal that this procedure is only for a command line case. Suggest altering the titles to reflect this and improve clarity for readers searching for module documentation.

@JustaSimpleUser
Update tutorial-import-stl-named-module.md
2f40001 
The Title of the document doesn't reveal that this procedure is only for a command line case.  Suggest altering the titles to reflect this and improve clarity for readers searching for module documentation.
@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

4 similar comments
@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 2f40001:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/tutorial-import-stl-named-module.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Feb 22, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Feb 22, 2023
@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

TylerMSFT
TylerMSFT requested changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. As a small request, could you please make 'Command Line' lowercase? We don't use that casing in headings.

@JustaSimpleUser
Update tutorial-import-stl-named-module.md
45bb818 
Changed the capitalization at Microsoft's request.
@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 45bb818:

✅ Validation status: passed

File Status Preview URL Details
docs/cpp/tutorial-import-stl-named-module.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@JustaSimpleUser : Thanks for your contribution! The author(s) have been notified to review your proposed change.

TylerMSFT
TylerMSFT approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I meant change the text that is visible - the heading.
I'll send this through and fix it later today.

@TylerMSFT TylerMSFT merged commit eebd25b into MicrosoftDocs:main Feb 23, 2023
learn-build-service-prod bot added a commit that referenced this pull request Feb 23, 2023
@learn-build-service-prod @huypub
@NelsonDaniel @colin-home @JustaSimpleUser
Confirm merge from FromPublicMasterBranch to main to sync with https:…
d264750 
…//github.com/MicrosoftDocs/cpp-docs (branch main) (#4817)

* Update vcperf-commands.md (#4375)

* Update vcperf-commands.md

Update commands according to https://github.com/microsoft/vcperf#command-line-reference

* Update vcperf-commands.md

* Update with grammar fixes for i18n

---------

Co-authored-by: Colin Robertson <[email protected]>

* Update tutorial-import-stl-named-module.md (#4429)

* Update tutorial-import-stl-named-module.md

The Title of the document doesn't reveal that this procedure is only for a command line case.  Suggest altering the titles to reflect this and improve clarity for readers searching for module documentation.

* Update tutorial-import-stl-named-module.md

Changed the capitalization at Microsoft's request.

---------

Co-authored-by: huypub <[email protected]>
Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com>
Co-authored-by: Nelson Daniel Troncoso <[email protected]>
Co-authored-by: Colin Robertson <[email protected]>
Co-authored-by: Centurion Maximus <[email protected]>
Jak-MS
Jak-MS reviewed Feb 23, 2023
View reviewed changes
TylerMSFT pushed a commit that referenced this pull request Feb 23, 2023
@learn-build-service-prod @AnjuDel
@prmerger-automator @huypub @NelsonDaniel @colin-home @JustaSimpleUser @Jak-MS
Resolve syncing conflicts from FromPrivateLiveToMaster to main (#4433)
2052907 
* rewording ReadString documentation to be more accurate (#4815)

* reword nmax parameter wording for ReadString to be more accurate

* change suggested directory location

* acrolinx

* incorp review

* fix path

* improve path

* Confirm merge from FromPublicMasterBranch to main to sync with https://github.com/MicrosoftDocs/cpp-docs (branch main) (#4817)

* Update vcperf-commands.md (#4375)

* Update vcperf-commands.md

Update commands according to https://github.com/microsoft/vcperf#command-line-reference

* Update vcperf-commands.md

* Update with grammar fixes for i18n

---------

Co-authored-by: Colin Robertson <[email protected]>

* Update tutorial-import-stl-named-module.md (#4429)

* Update tutorial-import-stl-named-module.md

The Title of the document doesn't reveal that this procedure is only for a command line case.  Suggest altering the titles to reflect this and improve clarity for readers searching for module documentation.

* Update tutorial-import-stl-named-module.md

Changed the capitalization at Microsoft's request.

---------

Co-authored-by: huypub <[email protected]>
Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com>
Co-authored-by: Nelson Daniel Troncoso <[email protected]>
Co-authored-by: Colin Robertson <[email protected]>
Co-authored-by: Centurion Maximus <[email protected]>

* fix casing and wording

* acrolinx

---------

Co-authored-by: Anju del Moral Gonzalez <[email protected]>
Co-authored-by: TylerMSFT <[email protected]>
Co-authored-by: prmerger-automator[bot] <40007230+prmerger-automator[bot]@users.noreply.github.com>
Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com>
Co-authored-by: huypub <[email protected]>
Co-authored-by: Nelson Daniel Troncoso <[email protected]>
Co-authored-by: Colin Robertson <[email protected]>
Co-authored-by: Centurion Maximus <[email protected]>
Co-authored-by: Jak Koke <[email protected]>
@JustaSimpleUser
Copy link
Contributor Author

JustaSimpleUser commented Feb 24, 2023 via email

@TylerMSFT
Copy link
Collaborator

@JustaSimpleUser , no worries. The important thing is that we got your improvement in, and I think it was a good thing to add. Thank you for taking the time.

vaanwd pushed a commit to vaanwd/cpp-docs that referenced this pull request Mar 1, 2023
@denrea
Merge pull request MicrosoftDocs#4429 from MugBergerFries/patch-1
9942070 
Updated C6101
@0000854453 0000854453 linked an issue Jul 7, 2023 that may be closed by this pull request
§§ #4620
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerMSFT TylerMSFT TylerMSFT approved these changes

@Jak-MS Jak-MS Jak-MS left review comments

Assignees

@TylerMSFT TylerMSFT

Labels
aq-pr-triaged Tracking label for the PR review team Change sent to author cpp-language/tech do-not-merge qualifies-for-auto-merge visual-cpp/prod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

§§
4 participants
@JustaSimpleUser @Court72 @TylerMSFT @Jak-MS