Skip to content

masm/bnf-grammar: Format some literal characters correctly #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

lkundrak
Copy link
Contributor

@lkundrak lkundrak commented Mar 7, 2023

A couple of character literal terminals don't follow consistent formatting. Fix that.

A couple of character literal terminals don't follow consistent
formatting. Fix that.
@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

4 similar comments
@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b3dc4de:

✅ Validation status: passed

File Status Preview URL Details
docs/assembler/masm/masm-bnf-grammar.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about the value of these changes. One of the reasons we do code escape is to prevent machine translation of identifiers. But that's not an issue with parenthesis, etc.
I'll take the change since the work is done, but I wouldn't necessarily encourage further work like this unless it is to prevent machine translation from incorrectly modifying a code statement.

@TylerMSFT
Copy link
Collaborator

#sign-off

@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

1 similar comment
@prmerger-automator
Copy link
Contributor

@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the changes.

@TylerMSFT TylerMSFT merged commit 07f4092 into MicrosoftDocs:main Mar 7, 2023
@0000854453 0000854453 linked an issue Jul 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

§§
2 participants