-
Notifications
You must be signed in to change notification settings - Fork 967
masm/bnf-grammar: Format some literal characters correctly #4456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A couple of character literal terminals don't follow consistent formatting. Fix that.
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
4 similar comments
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit b3dc4de: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence about the value of these changes. One of the reasons we do code escape is to prevent machine translation of identifiers. But that's not an issue with parenthesis, etc.
I'll take the change since the work is done, but I wouldn't necessarily encourage further work like this unless it is to prevent machine translation from incorrectly modifying a code statement.
#sign-off |
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
1 similar comment
@lkundrak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the changes.
A couple of character literal terminals don't follow consistent formatting. Fix that.