Correct documentation for HFA return values #4527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listed rules for HVA return values was correct, but for HFAs it matters whether or not the type is an aggregate.
|
@sigatrev : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
cpp-tools/tech
visual-cpp/prod
Change sent to author
labels
|
Learn Build status updates of commit 6d88468: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
#sign-off |
| @@ -204,7 +204,7 @@ A type is considered to be an HFA or HVA if all of the following hold: | |||
| - It doesn't have any non-trivial default or copy constructors, destructors, or assignment operators, | |||
| - All of its members have the same HFA or HVA type, or are float, double, or neon types that match the other members' HFA or HVA types. | |||
|
|
|||
| HFA and HVA values with four or fewer elements are returned in s0-s3, d0-d3, or v0-v3, as appropriate. | |||
| HVA values with four or fewer elements are returned in s0-s3, d0-d3, or v0-v3, as appropriate. | |||
|
|
|||
| Types returned by value are handled differently depending on whether they have certain properties, and whether the function is a non-static member function. Types which have all of these properties, | |||
There was a problem hiding this comment.
Maybe clearer to explicitly state "non-HVA types" here?
There was a problem hiding this comment.
Actually, nevermind; there are rules for both HVAs and HFAs that aren't stated here, so that fix doesn't really help. I'm trying to work out the exact rules...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listed rules for HVA return values was correct, but for HFAs it matters whether or not the type is an aggregate.