Clarify terminology around register volatility. #4547
Conversation
…t in the industry, register calling convention assignment are more frequently referred to as Caller vs Callee saved. Also, x18 is a reserved register, so it is neither Caller nor Callee Saved.
|
@pmsjt : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
cpp-tools/tech
Change sent to author
visual-cpp/prod
labels
|
Learn Build status updates of commit 7033bfd: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
There was a problem hiding this comment.
Hi @pmsjt, it was cool of you to update this page. I'm unfortunately not going to take this PR because although I think you are right that caller-saved and callee-saved are more widely used outside of MS, these changes then make this one doc inconsistent with our other docs. For better or for worse, MS went down the road of this terminology and I'd want to make a MS-wide change to our documentation rather than become inconsistent with ourselves. It's not a wonderful situation but I unfortunately don't have the time to undertake such an effort.
|
@TylerMSFT, @Court72 please reopen the PR so I can address the feedback. I don't have the permissions to do so. If you Close the PR I can't address the comments. |
|
Learn Build status updates of commit 7033bfd: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
…ly had objectively incorrect descriptions.
|
Learn Build status updates of commit 62dacd7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit ec8ef03: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
prmerger-automator
bot
added
qualifies-for-auto-merge
and removed
qualifies-for-auto-merge
labels
|
Thank you for the feedback @TylerMSFT. I agree it is best to keep terminology consistent. I revised the change to touch only the cases where taxonomy was objectively incorrect and aimed to clarify the usage without introducing new terminology. Please let me know if this is more palatable. |
|
Learn Build status updates of commit cc1de7e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
…so be result registers.
|
Learn Build status updates of commit a50e913: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Thanks for reviewing the proposed changes. When the changes are ready for publication, add a |
|
#sign-off |
Volatile vs Non-volatile is a very Microsoft specific terminology. Out in the industry, register calling convention assignment are more frequently referred to as Caller vs Callee saved.
Also, x18 is a reserved register, so it is neither Caller nor Callee Saved.