Skip to content

Update get-timezone.md #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Update get-timezone.md #4576

merged 2 commits into from
Jun 5, 2023

Conversation

stephen9357
Copy link
Contributor

Add a hint to avoid calling _get_timezone always returns the default value.

Add a hint to avoid calling _get_timezone always returns the default value.
@prmerger-automator
Copy link
Contributor

@stephen9357 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 675ea0f:

✅ Validation status: passed

File Status Preview URL Details
docs/c-runtime-library/reference/get-timezone.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jun 5, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jun 5, 2023
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo on value. Also, consider rewording to put the reason first and the corrective action second, e.g. "If you don't want the default value, call _tzset first to initialize the timezone." I also added code escape for code so that machine translation doesn't take a shot at it for other languages.

Fixed typo. Slight rewording.
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and fixed the typo and did the small rewording.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c0903a4:

✅ Validation status: passed

File Status Preview URL Details
docs/c-runtime-library/reference/get-timezone.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@TylerMSFT
Copy link
Collaborator

#sign-off

@TylerMSFT TylerMSFT merged commit e9e1a38 into MicrosoftDocs:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants