-
Notifications
You must be signed in to change notification settings - Fork 967
Update get-timezone.md #4576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get-timezone.md #4576
Conversation
Add a hint to avoid calling _get_timezone always returns the default value.
@stephen9357 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 675ea0f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo on value. Also, consider rewording to put the reason first and the corrective action second, e.g. "If you don't want the default value, call _tzset
first to initialize the timezone." I also added code escape for code so that machine translation doesn't take a shot at it for other languages.
Fixed typo. Slight rewording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and fixed the typo and did the small rewording.
Learn Build status updates of commit c0903a4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
#sign-off |
Add a hint to avoid calling _get_timezone always returns the default value.