Skip to content

Cleanup minor inaccuracies in noalias #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2017
Merged

Cleanup minor inaccuracies in noalias #46

merged 2 commits into from
Jul 19, 2017

Conversation

BillyONeal
Copy link
Contributor

42: The word directly was written in code font, but the intent here was for it to be in italics.
47: Removed note that malloc (and by extension, free) are annoated __declspec(noalias). malloc and free touch errno, which is a global variable not directly pointed at by one of their parameters, and thus are inappropriate to mark with noalias.

42: The word directly was written in code font, but the intent here was for it to be in italics.
47: Removed note that malloc (and by extension, free) are annoated __declspec(noalias). malloc and free touch errno, which is a global variable not directly pointed at by one of their parameters, and thus are inappropriate to mark with noalias.
@msftclas
Copy link

@BillyONeal,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Copy link
Contributor

@mikeblome mikeblome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@mikeblome mikeblome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@mikeblome mikeblome merged commit 084ea4c into MicrosoftDocs:master Jul 19, 2017
@colin-home
Copy link
Contributor

Was there a preview build of this? I'm concerned that the whitespace stripped out is going to play hob with the rendered formatting.

@BillyONeal
Copy link
Contributor Author

VS Code is happy with it
2017-07-19_16-45-34

@mikeblome
Copy link
Contributor

mikeblome commented Jul 19, 2017 via email

@BillyONeal
Copy link
Contributor Author

@mikeblome Nope

@colin-home
Copy link
Contributor

There's a reason there are two spaces at the end of each "paragraph" and on each intentionally blank line, having to do with the way our markdown to HTML conversion works. Without them, the HTML renderer merges the content into one big paragraph, which looks pretty bad. I see a complete lack of such whitespace in the final changes.

@mikeblome
Copy link
Contributor

mikeblome commented Jul 19, 2017 via email

@colin-home
Copy link
Contributor

That's true. Either the OPS build is different from the directly rendered changes here, or I missed a change notice. I'll try an experiment and see. I've always hated the trailing spaces requirement and would be delighted if it's gone away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants