-
Notifications
You must be signed in to change notification settings - Fork 967
Cleanup minor inaccuracies in noalias
#46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
42: The word directly was written in code font, but the intent here was for it to be in italics. 47: Removed note that malloc (and by extension, free) are annoated __declspec(noalias). malloc and free touch errno, which is a global variable not directly pointed at by one of their parameters, and thus are inappropriate to mark with noalias.
@BillyONeal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
Was there a preview build of this? I'm concerned that the whitespace stripped out is going to play hob with the rendered formatting. |
@mikeblome Nope |
There's a reason there are two spaces at the end of each "paragraph" and on each intentionally blank line, having to do with the way our markdown to HTML conversion works. Without them, the HTML renderer merges the content into one big paragraph, which looks pretty bad. I see a complete lack of such whitespace in the final changes. |
That's true. Either the OPS build is different from the directly rendered changes here, or I missed a change notice. I'll try an experiment and see. I've always hated the trailing spaces requirement and would be delighted if it's gone away. |
42: The word directly was written in code font, but the intent here was for it to be in italics.
47: Removed note that malloc (and by extension, free) are annoated __declspec(noalias). malloc and free touch errno, which is a global variable not directly pointed at by one of their parameters, and thus are inappropriate to mark with noalias.